Retry transient leaderboard loads - #654
Draft
zacjones93 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The PostHog stack for issue 019fa481-8312-7bd1-a196-4cf75428890c resolves to the TanStack Start server-function transport used by the public leaderboard. When the route loader returned no initial data, the component fallback made a single request; a transient mobile Safari
TypeError: Load failedimmediately replaced the leaderboard with a blocking error state.The fallback now retries only browser network
TypeErrormessages (Load failed,Failed to fetch, and Firefox's equivalent) after 300ms and 900ms. Other errors retain the existing immediate failure behavior.Validation
pnpm --filter wodsmith-start exec vitest run test/components/leaderboard-page-content.test.tsx— 21 passedpnpm --filter wodsmith-start type-check— passednpx lat.md check— passedThe full suite completed with 2,913 tests passing and 11 unrelated existing failures/timeouts in competition-invite and Stripe webhook tests.
Summary by cubic
Add transient retry to leaderboard loads to prevent a blocking error when a browser fetch fails. Non-network errors still fail fast.
TypeErrornetwork failures (“Failed to fetch”, “Load failed”, Firefox equivalent) after 300ms and 900ms when the route loader returns no data.lat.md/architecture.mdunder “Transient leaderboard recovery”.Written for commit 12cbcec. Summary will update on new commits.