Skip to content

Add benchmark absolute-tier scoring - #568

Merged
zacjones93 merged 1 commit into
feat/hillerfit-planfrom
codex/hillerfit-m2-absolute-tier
Jun 21, 2026
Merged

Add benchmark absolute-tier scoring#568
zacjones93 merged 1 commit into
feat/hillerfit-planfrom
codex/hillerfit-m2-absolute-tier

Conversation

@zacjones93

@zacjones93 zacjones93 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add the M2 pure absolute-tier scoring engine with preloaded threshold context and fail-closed variant/table validation
  • Add benchmark category aggregation, tier-histogram tiebreaking, and half-tier leaderboard point formatting
  • Update benchmark docs/LAT to make the training PDF source-data-only and keep HillerFit-branded customer-facing surfaces out of scope

Verification

  • PATH="/Users/zacjones/.nvm/versions/node/v24.15.0/bin:/Users/zacjones/.codex/tmp/arg0/codex-arg05l7sL2:/Users/zacjones/.antigravity/antigravity/bin:/Users/zacjones/.bun/bin:/Users/zacjones/Documents/02.Areas/ai/claude-agents/bin:/Users/zacjones/.opencode/bin:/Users/zacjones/Library/pnpm:/Users/zacjones/.local/bin:/opt/homebrew/opt/openjdk@11/bin:/opt/homebrew/opt/postgresql@12/bin:/Users/zacjones/.rbenv/shims:/Users/zacjones/.rbenv/bin:/usr/local/sbin:/opt/homebrew/Cellar/ffmpeg/5.0.1_2/bin:/opt/homebrew/opt/openssl@3/bin:/Users/zacjones/.rbenv/shims:/Users/zacjones/.nvm/versions/node/v22.17.1/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/Users/zacjones/.cargo/bin:/Users/zacjones/.local/bin:/Applications/Codex.app/Contents/Resources" pnpm --filter wodsmith-start exec vitest run test/lib/scoring/absolute-tier.test.ts test/lib/scoring/category-aggregation.test.ts test/lib/scoring/format-points.test.ts test/lib/scoring/factory.test.ts test/lib/scoring/tiebreakers.test.ts test/schemas/scoring.test.ts
  • PATH="/Users/zacjones/.nvm/versions/node/v24.15.0/bin:/Users/zacjones/.codex/tmp/arg0/codex-arg05l7sL2:/Users/zacjones/.antigravity/antigravity/bin:/Users/zacjones/.bun/bin:/Users/zacjones/Documents/02.Areas/ai/claude-agents/bin:/Users/zacjones/.opencode/bin:/Users/zacjones/Library/pnpm:/Users/zacjones/.local/bin:/opt/homebrew/opt/openjdk@11/bin:/opt/homebrew/opt/postgresql@12/bin:/Users/zacjones/.rbenv/shims:/Users/zacjones/.rbenv/bin:/usr/local/sbin:/opt/homebrew/Cellar/ffmpeg/5.0.1_2/bin:/opt/homebrew/opt/openssl@3/bin:/Users/zacjones/.rbenv/shims:/Users/zacjones/.nvm/versions/node/v22.17.1/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/Users/zacjones/.cargo/bin:/Users/zacjones/.local/bin:/Applications/Codex.app/Contents/Resources" pnpm --filter wodsmith-start type-check
  • git diff --check
  • lat check (fails only existing Crew refs: lat.md/crew.md:7, lat.md/crew.md:9, lat.md/crew.md:217, apps/crew/test/routes/event-import-tabs.test.tsx:22)
  • pre-push hook: pnpm lint and pnpm type-check completed; lint emitted existing repo warnings

Reviewer Agreement

  • Bacon and Godel reviewed the M2 diff independently
  • Both agreed the final fail-closed variant/table ordering satisfies M2 after the inactive-score fix

Summary by cubic

Adds absolute-tier benchmark scoring with preloaded threshold context, category aggregation to Overall/100, and a tier-histogram tiebreaker to rank ties correctly. Updates leaderboard formatting and schema validation, and clarifies docs that the training PDF is source data only (no branded UI).

  • New Features
    • Implemented absolute_tier engine with fail-closed variant/table checks and getSortDirection-driven direction.
    • Added category aggregation (weighted mean, no second rescale) and Overall/100 computation.
    • Introduced benchmark tier-histogram tiebreaker; replaces field-relative countback for benchmark ties.
    • Added formatLeaderboardPoints to preserve half tiers; wired into competition and online leaderboards.
    • Extended scoring dispatcher to accept preloaded absolute-tier context; returns points/ranks per event.
    • Tightened scoringConfig validation: requires absoluteTier.batteryId only for absolute_tier and rejects stale config otherwise.
    • Comprehensive tests for engine, aggregation, tiebreakers, dispatcher, and formatting.
    • Documentation updates: the training PDF is source data only; no HillerFit-branded pages, routes, tabs, stats, navigation, logos, CTAs, or themes.

Written for commit 95d9913. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@zacjones93, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8bfc5614-53b6-4cb0-a3b4-eb10dac47e65

📥 Commits

Reviewing files that changed from the base of the PR and between cb30031 and 95d9913.

📒 Files selected for processing (26)
  • ai/research/hillerfit-benchmark-leaderboard-guide.md
  • ai/research/hillerfit-benchmark-leaderboard/README.md
  • ai/research/hillerfit-benchmark-leaderboard/assumptions-and-decisions.md
  • ai/research/hillerfit-benchmark-leaderboard/requirements.md
  • ai/research/hillerfit-benchmark-leaderboard/reviewer-alignment.md
  • ai/research/hillerfit-benchmark-leaderboard/tasks.md
  • ai/research/hillerfit-benchmark-leaderboard/technical-design.md
  • ai/research/hillerfit-benchmark-leaderboard/test-strategy.md
  • ai/research/hillerfit-benchmark-leaderboard/traceability.md
  • apps/wodsmith-start/src/components/competition-leaderboard-table.tsx
  • apps/wodsmith-start/src/components/online-competition-leaderboard-table.tsx
  • apps/wodsmith-start/src/lib/scoring/algorithms/absolute-tier.ts
  • apps/wodsmith-start/src/lib/scoring/algorithms/index.ts
  • apps/wodsmith-start/src/lib/scoring/category-aggregation.ts
  • apps/wodsmith-start/src/lib/scoring/format/index.ts
  • apps/wodsmith-start/src/lib/scoring/format/points.ts
  • apps/wodsmith-start/src/lib/scoring/index.ts
  • apps/wodsmith-start/src/lib/scoring/tiebreakers.ts
  • apps/wodsmith-start/src/schemas/scoring.schema.ts
  • apps/wodsmith-start/test/lib/scoring/absolute-tier.test.ts
  • apps/wodsmith-start/test/lib/scoring/category-aggregation.test.ts
  • apps/wodsmith-start/test/lib/scoring/factory.test.ts
  • apps/wodsmith-start/test/lib/scoring/format-points.test.ts
  • apps/wodsmith-start/test/lib/scoring/tiebreakers.test.ts
  • apps/wodsmith-start/test/schemas/scoring.test.ts
  • lat.md/domain.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/hillerfit-m2-absolute-tier

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zacjones93
zacjones93 merged commit c785244 into feat/hillerfit-plan Jun 21, 2026
15 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95d9913e04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +175 to +176
if (config.secondary && hasTies(athletes)) {
athletes = applyTiebreakerMethod(athletes, config.secondary, config)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve histogram winners when applying secondary ties

When an absolute-tier tie group has config.secondary set and the tier histogram only leaves a subset tied, this calls the secondary tiebreaker on the entire group. applyHeadToHead/applyCountback recompute tieRank from scratch, so an athlete who already won the benchmark tier histogram can be moved behind someone they beat by histogram; the secondary should only run within equal-histogram subgroups.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant