[codex] Add benchmark schema primitives - #565
Conversation
|
Warning Review limit reached
More reviews will be available in 20 minutes and 1 second. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (35)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
70442e8 to
bd24b45
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd24b45000
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "winner_takes_more", | ||
| "online", | ||
| "custom", | ||
| "absolute_tier", |
There was a problem hiding this comment.
When a seeded benchmark board stores settings.scoringConfig.algorithm === "absolute_tier", the organizer/cohost scoring pages parse that value and render ScoringSettingsForm, but saving posts it to updateCompetitionScoringConfigInputSchema/cohostScoringConfigInputSchema, whose hard-coded enums still omit this new algorithm. That means pressing Save on an unchanged benchmark scoring config fails validation before the handler, so benchmark boards cannot persist scoring settings from the visible scoring route; update those validators or hide the generic scoring form for benchmark boards.
Useful? React with 👍 / 👎.
1 participant
Summary
Adds the M1a benchmark schema primitives on top of the M0a capability-registry work that already landed in
feat/hillerfit-plan.track_workoutsandscores.benchmarkVariantfor variant-aware scoring.benchmarkpersistence value does not leak into generic create/edit pickers or silently downgrade existing rows.Branding / Source Boundary
This does not add HillerFit-branded pages, routes, product navigation, marketing copy, logos, theme treatments, or app strings. The local training PDF remains a source artifact for the upcoming M1b seed-data slice only; shipped UI remains the generic WODsmith benchmark experience.
Verification
pnpm --dir apps/wodsmith-start test test/components/organizer-competition-edit-form.test.tsx test/schemas/benchmark.test.ts test/schemas/scoring.test.ts test/lib/scoring/factory.test.ts test/lib/competitions/capabilities.test.ts test/lib/competitions/venue-volunteer-gates.test.ts test/routes/api/compete/scores/window-status.test.ts test/routes/api/compete/submission-gates.test.ts test/server-fns/athlete-score-fns.test.ts test/server-fns/video-submission-fns.test.ts test/routes/compete/video-submission-route-gates.test.ts(11 files, 164 tests)pnpm --filter @repo/wodsmith-db type-checkpnpm --dir apps/wodsmith-start type-checkpnpm --filter crew type-checkpnpm --dir apps/wodsmith-start lint(passes with existing warnings)pnpm check:schema-ownershipgit diff --checkrg -n "HillerFit|hillerfit" apps/wodsmith-start/src apps/crew/src packages/wodsmith-db/src apps/wodsmith-start/test apps/crew/test packages/wodsmith-db/mysql-migrations || truereturned no matchesgit push --force-with-leasepre-push hook ranpnpm lintandpnpm type-checksuccessfullylat checkwas also run and still fails only on pre-existing Crew LAT refs unrelated to this branch:lat.md/crew.md:7broken[[apps/crew/src/server-fns]]lat.md/crew.md:9broken[[apps/crew/src/server]]lat.md/crew.md:217broken[[apps/crew/src/lib/crew/templates]]apps/crew/test/routes/event-import-tabs.test.tsx:22broken@lat: [[crew#Import Tabs Duplicate Panel Regression]]