⚡ Bolt: [performance improvement] Optimize Temporal Context Copy Dictionary Allocations#322
Conversation
…ntext copies Replaces LINQ's `.ToDictionary(pair => pair.Key, pair => pair.Value, Comparer)` with the native `Dictionary` copy constructor `new Dictionary<string, double>(source, Comparer)`. This removes enumerable closures and delegate overhead in hot paths during `TemporalNetworkSimulationEngine.cs`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced LINQ
.ToDictionaryallocations forSupply,SupplyUnitCosts, andDemandwith the nativeDictionarycopy constructor inTemporalNetworkSimulationEngine.cs. Added an entry to.jules/bolt.md.🎯 Why:
ToDictionaryinvokes LINQ delegate closures (pair => pair.Key) per element, generating massive garbage on hot paths. The copy constructor leverages native fast-paths forIDictionaryimplementations, pre-allocating the correct count and copying values directly.📊 Impact: Removes multiple lambda delegate closures and enumeration overhead per context creation, significantly reducing GC pressure and allocations during network simulation graph evaluation.
🔬 Measurement: Use
.NET Memory Profileror BenchmarkDotNet to observe the drop inAction<KeyValuePair<...>>closure allocations insideToRoutingContext. Ensure tests run locally.PR created automatically by Jules for task 4408672459242420326 started by @wnj00524