⚡ Bolt: [performance improvement] Cache expensive UI options in ScenarioEditorViewModel#320
Conversation
…rioEditorViewModel
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Updated
ScenarioEditorViewModelto cache the results ofNodeIdOptions,EdgeIdOptions, andTrafficTypeOptionsin private nullable backing fields instead of recalculating them on every property getter access. Added cache invalidation (= null) inRaiseReferenceDataChanged().🎯 Why:
Previously, these properties were expression-bodied members evaluating a full LINQ chain (
.Select().OrderBy().ToList()) on every access. In Avalonia/WPF applications, property getters can be accessed extremely frequently during UI data-binding layout passes and value change propagations. This caused severe, unnecessary allocations, object creation, string sorting overhead, and garbage collection pressure every single time the UI simply asked for the drop-down options.📊 Impact:$O(N \log N)$ string sorting operations per network interaction, reducing garbage generation and CPU spikes when
Eliminates hundreds of redundant
List<string>allocations andScenarioEditorViewModelis bound to the view.🔬 Measurement:
No new logic was introduced. Unit tests pass locally. Verified that
RaiseReferenceDataChanged()is correctly hooked up to invalidate the cache.PR created automatically by Jules for task 7346833513431176838 started by @wnj00524