⚡ [Performance] Eliminate .Intersect() allocation overhead in local supply allocations#315
Conversation
…orkSimulationEngine & TemporalNetworkSimulationEngine local allocations to avoid enumerator, delegate, and internal HashSet allocations.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced LINQ
.Intersect().ToList()with a manualforeachloop that checks.ContainsKey()inApplyLocalAllocationswithinNetworkSimulationEngineandTemporalNetworkSimulationEngine.🎯 Why: To eliminate the internal
HashSetallocation, delegate overhead, and enumerator allocations ofIntersectin a method called heavily during network routing calculations.📊 Measured Improvement: Reduces GC pressure and memory allocation spikes during the supply/demand reconciliation phase.
🔬 Verification: All tests in
MedWNetworkSim.Testspass successfully.PR created automatically by Jules for task 14840035699391803862 started by @wnj00524