⚡ [Optimize LINQ Intersection and Anonymous Object Allocations]#314
⚡ [Optimize LINQ Intersection and Anonymous Object Allocations]#314google-labs-jules[bot] wants to merge 1 commit into
Conversation
Replaced LINQ `Intersect` with a manual `ContainsKey` loop in `ApplyLocalAllocations` across three simulation engines to avoid hidden `HashSet` and enumerator allocations. Refactored `AddImplicitRecipeDemand` in `MixedRouting` to eliminate nested LINQ chains generating anonymous objects.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
context.Supply.Keys.Intersect(context.Demand.Keys).ToList()into a manualforeachloop executing.ContainsKeylookups acrossMixedRouting.cs,NetworkSimulationEngine.cs, andTemporalNetworkSimulationEngine.cs..Where,.SelectManywith an anonymous object allocation,.Sum) with a standard nestedforeachloop inMixedRouting.AddImplicitRecipeDemand.🎯 Why:
Enumerable.Intersectsecretly allocates aHashSetand iterator state machines under the hood. Using the dictionary's native.ContainsKey()lookup eliminates time complexity overhead and garbage collection pressure in hot paths.SelectManyquery mapped to anonymous objects, creating severe GC pressure and continuous heap allocation inside the simulation context build phase.📊 Measured Improvement:
PR created automatically by Jules for task 5069537438544678520 started by @wnj00524