⚡ Bolt: Remove LINQ ToDictionary allocations on hot paths#310
⚡ Bolt: Remove LINQ ToDictionary allocations on hot paths#310google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced numerous high-overhead LINQ allocations (
.ToDictionary(),.GroupBy(),.Where(), etc.) with manual looping and pre-sized dictionaries inNetworkSimulationEngine.cs,TemporalNetworkSimulationEngine.cs, andMixedRouting.cs.🎯 Why: In high-frequency hot paths like routing simulations, chaining LINQ
.ToDictionary()forces the CLR to allocate delegates, closures, intermediate sequences, and dictionary wrappers. This generates massive garbage collection pressure. Pre-sizing and manually populating standard loops entirely eliminates this overhead.📊 Impact: Reduces memory allocations during network simulation iterations and improves overall throughput.
🔬 Measurement: Verified functionality is identical by successfully running the MedWNetworkSim test suite. Tests pass without regressions.
PR created automatically by Jules for task 6166298327440255012 started by @wnj00524