⚡ Bolt: Replace LINQ ToDictionary allocations in ToRoutingContext hot path#300
⚡ Bolt: Replace LINQ ToDictionary allocations in ToRoutingContext hot path#300google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced LINQ
.ToDictionary(...)calls with a manualCloneDictionaryloop insideToRoutingContextinTemporalNetworkSimulationEngine.cs.🎯 Why:
ToRoutingContextis called heavily within the temporal simulation loop. LINQ's.ToDictionary()allocates enumerators and internal mapping delegates for each execution, leading to rapid garbage generation on this critical hot path. Manually pre-sizing and explicitly iterating eliminates these extraneous heap allocations.📊 Impact: Reduces GC allocations per batched routing calculation cycle, reducing garbage collection pressure directly on the engine's primary execution pipeline.
🔬 Measurement: Code correctly builds (
dotnet build). Formatter has run natively viadotnet format. The test suite confirms performance optimization maintains functionally identical execution (dotnet test).PR created automatically by Jules for task 16028878234771903883 started by @wnj00524