⚡ Bolt: Remove LINQ .ToDictionary() allocations in hot paths#299
⚡ Bolt: Remove LINQ .ToDictionary() allocations in hot paths#299google-labs-jules[bot] wants to merge 1 commit into
Conversation
…educe GC pressure Replaces `Enumerable.ToDictionary()` and `GroupBy().ToDictionary()` chain calls in `NetworkSimulationEngine` and `TemporalNetworkSimulationEngine` with manual, pre-sized `Dictionary` initializations. This eliminates runtime overhead caused by hidden enumerator allocations and delegate closures on frequently-executed critical paths like `Advance()`. Also manually replicated grouping and aggregation logic in `SummarizeLandedUnitCosts` to calculate exact delivered cost without generating temporary sequence abstractions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Replaced LINQ
.ToDictionary()and.GroupBy().ToDictionary()combinations with standardforeachandforloops populating pre-sized dictionaries inNetworkSimulationEngine.csandTemporalNetworkSimulationEngine.cs.🎯 Why:
Using LINQ
.ToDictionary()inside heavily utilized setup and iterative pathways (like the simulationAdvance()loop or static setup paths) creates significant GC pressure by allocating sequence enumerators and lambda delegates at runtime. Transitioning to explicit collections eliminates this overhead entirely.📊 Impact:
Substantially reduces memory heap allocations during multi-layer and temporal simulation loops by removing delegate allocations for dictionary projections and avoiding multi-pass iterations caused by grouping.
🔬 Measurement:
Ensure all 131 tests continue passing successfully. Verified memory benefits theoretically by checking IL structure (delegate vs direct indexer allocation).
PR created automatically by Jules for task 14428041820858984040 started by @wnj00524