wip: massive refactor of collection storage and layout - #32
Draft
wllfaria wants to merge 23 commits into
Draft
Conversation
wllfaria
force-pushed
the
refactor/schemas
branch
from
September 17, 2024 02:58
d0c5fb2 to
7648748
Compare
wllfaria
force-pushed
the
main
branch
2 times, most recently
from
October 2, 2024 13:17
07bacb0 to
92413dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, collections are stored as a tree, which looks very intuitive as a json of requests can easily be translated into a tree. But this added a lot of complexity when rendering and mutating objects, often having to traverse the tree and having to Rc or Arc everything.
This refactor intends to change all of that by reading a collection as separate slabs, which are vector-esque data structured that also provide access by a reliable key.
This basically touches everything inside of the project, as the tree is used by basically everything, but I do believe this is a change for good and that it will greatly improve the quality of the project.
The idea is that we will load the tree of requests and flatten it into a more linear structure whilst maintaining the hierarchy of folders and requests.
This PR will also be changing a lot of the current layout, as some stuff don't really make me happy as they are.