k8s rollout: restart by image (main) - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restart deployments by image on rollout, instead of a synthesized
variant=<folder>label selector.infra/k8s/rollout: newrollout-imageinput. Selection priority:rollout-deployments→rollout-labels→ image (default) → all. Image mode:kubectl get deploy -o json | jq (image startswith) | xargs kubectl rollout restart.docker/setup: no longer appendsvariant=<path>to the label selector.docker-build-and-deploy/docker-promote-to-environment: passrollout-image = <registry>/<image>.Why
The
variant=selector forced every infra repo to hand-patch avariant:label onto its deployments (and one image often backs several deployments). Matching on the just-built image is precise and needs no labels.Compatible
K8S_DEPLOYMENTS/K8S_LABELSstill act as overrides.rollout-imageis derived from the samesetupoutput that builds the pushed image, so it matches the deployed image on every branch. Applied identically to main/v1/v2 (verified: image computation is the same on all three; no tags in use).