Make insets of active state updatable - #5
Open
jonasbeckers wants to merge 2 commits into
Open
Conversation
djbe
requested changes
Apr 29, 2024
jonasbeckers
force-pushed
the
feature/update-insets-after-transition
branch
from
May 3, 2024 10:59
db327b6 to
9df0419
Compare
djbe
approved these changes
May 8, 2024
| let animationCompletion: (Bool) -> Void = { [weak self] _ in | ||
| for (_, view) in store { | ||
| view.removeFromSuperview() | ||
|
|
Contributor
There was a problem hiding this comment.
I think this isn't needed, as the callback closure you've configured above has a weak reference to instance. So once the placeholder view is deallocated, the closure will be deleted as well.
But… better safe than sorry 😉
|
|
||
| func updateConstraints(for view: UIView, insets: UIEdgeInsets) { | ||
| let constraints = Dictionary(grouping: view.constraints) { $0.identifier.flatMap { ConstraintIdentifier(rawValue: $0) } } | ||
| constraints[.top]?.forEach { $0.constant = insets.top } |
Contributor
There was a problem hiding this comment.
These can probably use first instead of forEach 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to manually update the insets after the state view is already added.