fix(api-client): reconnect in place instead of spawning a second /await socket [WPB-21916]#21448
Open
thisisamir98 wants to merge 1 commit into
Open
fix(api-client): reconnect in place instead of spawning a second /await socket [WPB-21916]#21448thisisamir98 wants to merge 1 commit into
thisisamir98 wants to merge 1 commit into
Conversation
…it socket When connect() was called while a ReconnectingWebSocket wrapper already existed, we allocated a new RWS instance and only fire-and-forget closed the old one. That could leave two OPEN /await sessions on the same client id — both could ping/pong, but Nginz fans notifications to only one, causing silent message loss (LIVE UI, no new notifications). Reuse the existing wrapper and call reconnect() instead. The library synchronously closes the underlying WebSocket in _disconnect before starting _connect, so the app never holds two competing sessions. Also update the connect() unit test to assert in-place reconnect rather than close + new instance.
thisisamir98
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver and
zskhan
as code owners
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connect() was called while a ReconnectingWebSocket wrapper already existed, we allocated a new RWS instance and only fire-and-forget closed the old one. That could leave two OPEN /await sessions on the same client id — both could ping/pong, but Nginz fans notifications to only one, causing silent message loss (LIVE UI, no new notifications).
Reuse the existing wrapper and call reconnect() instead. The library synchronously closes the underlying WebSocket in _disconnect before starting _connect, so the app never holds two competing sessions.
Also update the connect() unit test to assert in-place reconnect rather than close + new instance.