Skip to content

feat: implemented edit composite message (WPB-19102)#21329

Open
panuschek wants to merge 3 commits into
devfrom
feat/edit-composite-messages
Open

feat: implemented edit composite message (WPB-19102)#21329
panuschek wants to merge 3 commits into
devfrom
feat/edit-composite-messages

Conversation

@panuschek
Copy link
Copy Markdown
Collaborator

@panuschek panuschek commented May 18, 2026

StoryWPB-19102 [Web] Support editing a Composite message

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.81%. Comparing base (0424bd7) to head (63cd120).

Files with missing lines Patch % Lines
...rc/script/repositories/conversation/EventMapper.ts 0.00% 8 Missing and 1 partial ⚠️
...pt/repositories/cryptography/CryptographyMapper.ts 0.00% 4 Missing ⚠️
...epositories/conversation/ConversationRepository.ts 25.00% 3 Missing ⚠️
...iddleware/eventHandlers/getCommonMessageUpdates.ts 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #21329      +/-   ##
==========================================
- Coverage   45.83%   45.81%   -0.02%     
==========================================
  Files        1707     1707              
  Lines       44174    44191      +17     
  Branches     9183     9189       +6     
==========================================
+ Hits        20245    20246       +1     
- Misses      21650    21663      +13     
- Partials     2279     2282       +3     
Flag Coverage Δ
app_webapp 43.99% <13.63%> (-0.02%) ⬇️
lib_api_client 51.86% <ø> (ø)
lib_core 59.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sitories/conversation/EventBuilder/EventBuilder.ts 55.88% <ø> (ø)
...rageMiddleware/eventHandlers/editedEventHandler.ts 67.85% <100.00%> (+1.19%) ⬆️
...epositories/conversation/ConversationRepository.ts 46.45% <25.00%> (-0.09%) ⬇️
...iddleware/eventHandlers/getCommonMessageUpdates.ts 35.71% <0.00%> (-9.75%) ⬇️
...pt/repositories/cryptography/CryptographyMapper.ts 45.45% <0.00%> (-0.94%) ⬇️
...rc/script/repositories/conversation/EventMapper.ts 38.80% <0.00%> (-0.59%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 14
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 1
  • 📊 Total: 15
  • Total Runtime: 7606.6s (~ 126 min 47 sec)
specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Group Video call (tags: TC-8637, crit-flow-web)

@panuschek panuschek changed the title implemented edit composite message feat: implemented edit composite message (WPB-19102) May 19, 2026
@panuschek panuschek force-pushed the feat/edit-composite-messages branch from 0ea3d51 to b384cb0 Compare May 19, 2026 13:18
@panuschek panuschek marked this pull request as ready for review May 19, 2026 13:18
markbrockhoff
markbrockhoff previously approved these changes May 22, 2026
@panuschek panuschek force-pushed the feat/edit-composite-messages branch from b384cb0 to bc7389b Compare May 29, 2026 10:04
Comment thread apps/webapp/src/script/repositories/conversation/EventBuilder/EventBuilder.ts Outdated
Comment thread apps/webapp/src/script/repositories/conversation/ConversationRepository.ts Outdated
@panuschek panuschek force-pushed the feat/edit-composite-messages branch from bc7389b to fd3011d Compare June 2, 2026 12:18
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

@e-maad e-maad self-requested a review June 2, 2026 14:41
Copy link
Copy Markdown
Contributor

@e-maad e-maad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@e-maad e-maad self-requested a review June 2, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants