feat: Show offline indicator for files in conversation (WPB-23968)#4846
Open
ohassine wants to merge 24 commits into
Open
feat: Show offline indicator for files in conversation (WPB-23968)#4846ohassine wants to merge 24 commits into
ohassine wants to merge 24 commits into
Conversation
…to display-offline-files # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileActionsMenu.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/OfflineFileDownloadController.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/NodeBottomSheetAction.kt # features/cells/src/main/res/drawable/ic_cross_in_circle.xml
# Conflicts: # kalium
# Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
…to display-offline-files # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt # kalium
…to display-offline-files
…to show-offline-indicator-for-files-in-conversation # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsViewModel.kt
|
sbakhtiarov
reviewed
May 20, 2026
| else -> hiltViewModel<MultipartAttachmentsViewModelImpl>() | ||
| } | ||
| ) { | ||
| val offlineAttachmentIds by viewModel.offlineAttachmentIds.collectAsStateWithLifecycle() |
Contributor
There was a problem hiding this comment.
Suggestion: do not expose offlineAttachmentIds outside of viewmodel just for mapping.
Add mapAttachment(attachment) method for mapping one attachment and then both mapAttachment/mapAttachments can do the mapping using private offlineAttachmentIds in viewmodel.
| viewModel: MultipartAttachmentsViewModel = when { | ||
| LocalInspectionMode.current -> MultipartAttachmentsViewModelPreview | ||
| else -> hiltViewModel<MultipartAttachmentsViewModelImpl>(key = conversationId.value) | ||
| else -> hiltViewModel<MultipartAttachmentsViewModelImpl>() |
Contributor
There was a problem hiding this comment.
This change will create one view model per multipart view. Is this intended? This ViewModel was designed as single instance per conversation.
| private val conversationId = savedStateHandle.navArgs<ConversationNavArgs>().conversationId.value | ||
|
|
||
| private val uploadProgress = mutableStateMapOf<String, Float>() | ||
| override val offlineAttachmentIds: StateFlow<Set<String>> = observeOfflineFiles() |
Contributor
There was a problem hiding this comment.
Should we pass conversationId parameter to observeOfflineFiles(), to limit number of offline files by current conversation.
| */ | ||
| @Composable | ||
| fun MultipartAttachmentsView( | ||
| conversationId: ConversationId, |
Contributor
There was a problem hiding this comment.
Why the conversationId cannot be passed via view parameters anymore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23968
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description
Show offline indicator for files available offline in conversation screen
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.