fix(showcase): tighten docs spacing and sidebar padding#13
Conversation
|
🚀 PR Preview deployed!
Run |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d174714040
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| max-width: none; | ||
| margin: 0 auto; | ||
| padding: 1.9rem 1.6rem; | ||
| padding: 1.9rem 1.5rem; |
There was a problem hiding this comment.
This shared showcase.css change relies on cache-busting, but only some HTML files were moved to ?v=5; layout-utilities.html, slider.html, toggle.html, toggle-group.html, and toast.html still request ./showcase.css?v=3 (verified with rg "showcase\.css\?v=" showcase). Visitors with the old v=3 stylesheet cached will keep seeing the previous sidebar/layout spacing on those pages while the rest of the docs use the new CSS, so the showcase becomes inconsistent after deploy.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR tightens spacing in the showcase documentation layout (top bar + docs shell + sidebar nav) and updates most showcase HTML pages to reference a new showcase.css cache-busting version so the refreshed spacing is picked up in browsers.
Changes:
- Reduced horizontal padding in the docs top bar and main docs shell.
- Significantly reduced docs sidebar padding and adjusted sidebar nav-link padding.
- Bumped
showcase.cssquerystring version across many showcase HTML pages (?v=4→?v=5).
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| showcase/showcase.css | Tightens layout padding for topbar/shell/sidebar and densifies sidebar nav-link spacing. |
| showcase/buttons.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/cards.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/charts.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/code-block.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/components.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/data-display.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/feedback.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/forms.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/gallery.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/icons.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/index.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/installation.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout-app-shell.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout-content-grid.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout-entry-header.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout-example-app-shell.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout-example-sidebar.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout-example-topnav.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout-sidebar.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout-topnav.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/layout.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/mermaid.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/modal.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/navigation.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/tables.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/tags.html | Bumps showcase.css cache-busting version to ?v=5. |
| showcase/typography.html | Bumps showcase.css cache-busting version to ?v=5. |
| <link rel="stylesheet" href="../index.css" /> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/themes/prism-tomorrow.min.css" crossorigin /> | ||
| <link rel="stylesheet" href="./showcase.css?v=4" /> | ||
| <link rel="stylesheet" href="./showcase.css?v=5" /> |
Summary
Scope
showcase/showcase.cssNotes
This PR is created from the local staged changes that were present in the theme repository working tree.