Modernize to .NET 10 / C# 14, fix upstream bugs, Android 16KB page alignment, one-click NuGet CI by Copilot · Pull Request #1 · winnerspiros/veldrid-spirv

Copilot · 2026-04-19T20:40:15Z

Full modernization pass: upgrade from .NET 5/8 to .NET 10 with latest C#, incorporate all open bug fixes from upstream veldrid/veldrid-spirv, and make NuGet publishing a single workflow button click.

.NET & Language

All projects → net10.0, LangVersion=latest (C# 14), Nullable=enable, ImplicitUsings=enable
Applied modern patterns throughout: file-scoped namespaces, collection expressions, is null/is not null, switch expressions, source-generated [GeneratedRegex], expression-bodied members, primary constructors, string interpolation
Removed deprecated DotNetCliToolReference, System.Runtime.CompilerServices.Unsafe, test runner Program.cs
PackageLicenseUrl → PackageLicenseExpression

Upstream Bug Fixes

veldrid#32: Debug flag now propagated to cross-compiled shader descriptions in ResourceFactoryExtensions
veldrid#34: #include <cstdint> added for GCC 10+ native build compat
veldrid#21: SpirvCompilationException.Data now includes LineNumber and ShaderStage
CompileCompute interop bug: Was marshaling SpecializationConstant (managed) instead of NativeSpecializationConstant to native code — potential memory corruption

Android 16KB Page Size

if(ANDROID)
    target_link_options(veldrid-spirv PRIVATE "-Wl,-z,max-page-size=16384")
endif()

Required for Android 16 (API 36+). Without this, libveldrid-spirv.so fails the page size check on devices enforcing 16KB pages.

Package Updates

Package	Before	After
Nerdbank.GitVersioning	3.4.255	3.9.50
xunit	2.4	xunit.v3 3.2.2
Microsoft.NET.Test.Sdk	17.x	18.4.0
McMaster.Extensions.CommandLineUtils	4.0	5.1.0

CI/CD

.NET SDK 6.0 → 10.0, test runner dotnet run -p → dotnet test
Added linux-arm64 to test matrix
workflow_dispatch now has a publish_nuget boolean input — one-click NuGet publish from the Actions tab
--skip-duplicate on dotnet nuget push

Code Quality

Null safety: ArgumentNullException.ThrowIfNull, removed unsafe ! null-forgiving operators, added explicit null guards in VariantCompiler
Extracted duplicate JsonSerializer setup into WriteReflectionJson helper
Consolidated 4 redundant CrossCompileOptions constructors into 2 with delegation
Fixed confusing writeReflectionFile flag logic (renamed to isFirstTarget)
Updated README with full changelog vs ppy fork, fixed code examples, added NuGet publish instructions

…amespaces and latest patterns Agent-Logs-Url: https://github.com/winnerspiros/veldrid-spirv/sessions/cdba2021-18f0-4917-82ff-e741483fa17f Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…int fix, exception line numbers, Android 16KB page size, modernize CI workflow to .NET 10 with one-click NuGet publish Agent-Logs-Url: https://github.com/winnerspiros/veldrid-spirv/sessions/cdba2021-18f0-4917-82ff-e741483fa17f Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…nSerializer, consolidate constructors, switch expressions, updated README with changelog from ppy fork Agent-Logs-Url: https://github.com/winnerspiros/veldrid-spirv/sessions/cdba2021-18f0-4917-82ff-e741483fa17f Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…t null, string interpolation, expression bodies, LINQ simplification Agent-Logs-Url: https://github.com/winnerspiros/veldrid-spirv/sessions/cdba2021-18f0-4917-82ff-e741483fa17f Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

gitar-bot · 2026-04-19T20:40:19Z

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

Copilot

Pull request overview

Modernization and maintenance update that upgrades the repo to .NET 10/C# latest, pulls in upstream bug fixes for shader compilation/cross-compilation, adds Android 16KB page-size linker alignment, and streamlines CI/NuGet publishing.

Changes:

Upgrade projects to net10.0 with nullable + implicit usings; refactor to modern C# patterns across the codebase.
Fix/port upstream interop and diagnostics issues (debug flag propagation, specialization constant marshaling, better error metadata).
Update native/CI tooling (Android 16KB page alignment, linux-arm64 test matrix, one-click NuGet publish input).

Reviewed changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/libveldrid-spirv/libveldrid-spirv.cpp	Adds missing `<cstdint>` include for GCC 10+ compatibility.
src/Veldrid.SPIRV/VertexFragmentCompilationInfo.cs	Converts to file-scoped namespace; makes reflection nullable in result type.
src/Veldrid.SPIRV/VeldridSpirvNative.cs	Refactors to file-scoped namespace; keeps iOS resolver logic.
src/Veldrid.SPIRV/Veldrid.SPIRV.csproj	Targets net10.0; adds packed README for NuGet.
src/Veldrid.SPIRV/Util.cs	Modernizes nullability and file-scoped namespace.
src/Veldrid.SPIRV/SpirvReflection.cs	Refactors to file-scoped namespace and modern formatting.
src/Veldrid.SPIRV/SpirvCompilationResult.cs	Refactors to file-scoped namespace and modern formatting.
src/Veldrid.SPIRV/SpirvCompilationException.cs	Refactors to file-scoped namespace and modern formatting.
src/Veldrid.SPIRV/SpirvCompilation.cs	Major modernization; fixes specialization constant interop; adds richer error metadata.
src/Veldrid.SPIRV/ShadercShaderKind.cs	Refactors to file-scoped namespace and modern formatting.
src/Veldrid.SPIRV/ResourceFactoryExtensions.cs	Fixes debug flag propagation; refactors to modern C# constructs.
src/Veldrid.SPIRV/ReflectionInfo.cs	Refactors interop structs to file-scoped namespace.
src/Veldrid.SPIRV/NativeSpecializationConstant.cs	Refactors interop struct to file-scoped namespace.
src/Veldrid.SPIRV/NativeMacroDefinition.cs	Adds validation + refactor; introduces MaxBufferSize constant.
src/Veldrid.SPIRV/MacroDefinition.cs	Enables nullable value; modernizes constructors/properties.
src/Veldrid.SPIRV/InteropArray.cs	Hardens bounds checks; refactors layout to file-scoped namespace.
src/Veldrid.SPIRV/GlslCompileOptions.cs	Enables nullable usage patterns; uses collection expressions for defaults.
src/Veldrid.SPIRV/GlslCompileInfo.cs	Refactors interop struct to file-scoped namespace.
src/Veldrid.SPIRV/CrossCompileTarget.cs	Refactors enum to file-scoped namespace with docs cleanup.
src/Veldrid.SPIRV/CrossCompileOptions.cs	Consolidates constructors; modernizes defaults and initialization.
src/Veldrid.SPIRV/CrossCompileInfo.cs	Refactors interop struct to file-scoped namespace.
src/Veldrid.SPIRV/ComputeCompilationResult.cs	Refactors to file-scoped namespace and modern formatting.
src/Veldrid.SPIRV/CompilationResult.cs	Modernizes bounds checks; refactors interop struct formatting.
src/Veldrid.SPIRV/Bool32.cs	Refactors to file-scoped namespace; minor modernization.
src/Veldrid.SPIRV.VariantCompiler/Veldrid.SPIRV.VariantCompiler.csproj	Targets net10.0; updates CLI utils dependency.
src/Veldrid.SPIRV.VariantCompiler/Program.cs	Modernizes CLI program and JSON load flow.
src/Veldrid.SPIRV.VariantCompiler/CompilationSet.cs	Refactors variant compiler; improves error aggregation; extracts JSON writing helper.
src/Veldrid.SPIRV.Tests/Veldrid.SPIRV.Tests.csproj	Targets net10.0; migrates to xunit.v3 and modern test SDK.
src/Veldrid.SPIRV.Tests/TestUtil.cs	Refactors to file-scoped namespace and modern formatting.
src/Veldrid.SPIRV.Tests/ReflectionTests.cs	Updates tests for nullable reflection and modern C# syntax.
src/Veldrid.SPIRV.Tests/Program.cs	Removes deprecated custom xUnit console runner.
src/Veldrid.SPIRV.Tests/CompilationTests.cs	Updates tests to modern C# syntax and file-scoped namespace.
src/Veldrid.SPIRV.BuildTools/Veldrid.SPIRV.BuildTools.csproj	Targets net10.0; updates published tool path.
README.md	Updates documentation, changelog, CI instructions, and fixes sample code.
Directory.Build.props	Enables nullable/implicit usings/lang latest; switches to license expression; bumps Nerdbank.GV.
CMakeLists.txt	Adds Android 16KB page-size linker flag.
.github/workflows/build.yml	Updates CI for .NET 10, linux-arm64 tests, and manual NuGet publish input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-19T20:46:46Z

+    /// <param name="vertexElements">/// An array containing a description of each vertex element that is used by
+    /// the compiled shader set.</param>
+    /// <param name="resourceLayouts">An array containing a description of each set of resources used by the


The XML doc for vertexElements has an extra /// inside the <param> text, which will show up in generated docs and is likely unintended. Remove the stray /// so the parameter description renders correctly.

Copilot · 2026-04-19T20:46:47Z

+                string reflectionPath = Path.Combine(_outputPath, $"{variant.Name}_ReflectionInfo.json");
+                WriteReflectionJson(reflectionPath, result.Reflection);
+                generatedFiles.Add(reflectionPath);


CompileCompute writes *_ReflectionInfo.json inside the per-target loop, so the same file is overwritten for each target and the returned generatedFiles can contain duplicate reflection paths. Consider writing reflection once (e.g., on first successful target, similar to CompileVertexFragment) and only adding the path once.

Copilot · 2026-04-19T20:46:47Z

  <ItemGroup>
    <PackageReference Include="Veldrid.SPIRV" Version="1.0.14" />
-    <PackageReference Include="McMaster.Extensions.CommandLineUtils" Version="4.0.1" />
+    <PackageReference Include="McMaster.Extensions.CommandLineUtils" Version="5.1.0" />
  </ItemGroup>


This project is part of src/Veldrid.SPIRV.sln, but it references the Veldrid.SPIRV NuGet package instead of the in-repo Veldrid.SPIRV project. That can lead to building/running the VariantCompiler against a different version than the rest of the solution. Consider switching this to a ProjectReference (or aligning the package reference to the fork’s package ID/version) to avoid version skew.

Copilot · 2026-04-19T20:46:47Z

    <Content Include="TestShaders/*" CopyToOutputDirectory="PreserveNewest" />
    <Content Include="$(RepositoryRootDirectory)/build/$(Configuration)/win-x64/libveldrid-spirv.dll" Condition="Exists('$(RepositoryRootDirectory)/build/$(Configuration)/win-x64/libveldrid-spirv.dll')" CopyToOutputDirectory="PreserveNewest" />
    <Content Include="$(RepositoryRootDirectory)/build/$(Configuration)/osx/libveldrid-spirv.dylib" Condition="Exists('$(RepositoryRootDirectory)/build/$(Configuration)/osx/libveldrid-spirv.dylib')" CopyToOutputDirectory="PreserveNewest" />
    <Content Include="$(RepositoryRootDirectory)/build/$(Configuration)/linux-x64/libveldrid-spirv.so" Condition="Exists('$(RepositoryRootDirectory)/build/$(Configuration)/linux-x64/libveldrid-spirv.so')" CopyToOutputDirectory="PreserveNewest" />
  </ItemGroup>


The workflow now runs tests on linux-arm64, but the test project only copies the linux-x64 native library into the output. On ARM runners this likely results in DllNotFoundException at runtime. Add a conditional content item for build/$(Configuration)/linux-arm64/libveldrid-spirv.so (or otherwise ensure the ARM64 .so is placed on the test output path).

Copilot · 2026-04-19T20:46:47Z

  create: # when tags are created
  push:
    branches: [ master ]


on: create triggers for both branch and tag creation, but the comment suggests it is intended only for tags. If the goal is to run CI only for tags, consider removing create and using push: tags: (or add job-level if: guards) to avoid running the full matrix on branch creation events.

Suggested change

create: # when tags are created

push:

branches: [ master ]

push:

branches: [ master ]

tags: [ '*' ]

Copilot AI and others added 4 commits April 19, 2026 20:17

Copilot AI assigned Copilot and winnerspiros Apr 19, 2026

Copilot created this pull request from a session on behalf of winnerspiros April 19, 2026 20:40 View session

winnerspiros marked this pull request as ready for review April 19, 2026 20:40

Copilot AI review requested due to automatic review settings April 19, 2026 20:40

winnerspiros merged commit 5ebc751 into master Apr 19, 2026
2 checks passed

Copilot started reviewing on behalf of winnerspiros April 19, 2026 20:40 View session

Copilot AI reviewed Apr 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize to .NET 10 / C# 14, fix upstream bugs, Android 16KB page alignment, one-click NuGet CI#1

Modernize to .NET 10 / C# 14, fix upstream bugs, Android 16KB page alignment, one-click NuGet CI#1
winnerspiros merged 4 commits into
masterfrom
copilot/optimize-and-modernize-project

Copilot AI commented Apr 19, 2026

Uh oh!

gitar-bot Bot commented Apr 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 19, 2026

.NET & Language

Upstream Bug Fixes

Android 16KB Page Size

Package Updates

CI/CD

Code Quality

Uh oh!

gitar-bot Bot commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gitar-bot Bot commented Apr 19, 2026 •

edited

Loading