fix: consolidate progress saves to prevent duplicate API calls on teardown#31
Open
Syed-Moiz-Ali wants to merge 1 commit into
Open
fix: consolidate progress saves to prevent duplicate API calls on teardown#31Syed-Moiz-Ali wants to merge 1 commit into
Syed-Moiz-Ali wants to merge 1 commit into
Conversation
Syed-Moiz-Ali
force-pushed
the
fix/duplicate-progress-saves
branch
from
4a195fe to
31bb4cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description\n\nAdds a _progressSavedOnExit\ flag to consolidate progress saving logic. When the user navigates back via _navigateBack(), the flag is set before saving. The \dispose()\ method then skips its own save if the flag is already true, preventing redundant identical API requests.\n\n## Fixes\n\nFixes #15 — Bug: Duplicate API calls to save progress on VideoPlayer teardown