fix: delay VideoPlayerController disposal to avoid crash on HQ switch#28
Open
Syed-Moiz-Ali wants to merge 1 commit into
Open
fix: delay VideoPlayerController disposal to avoid crash on HQ switch#28Syed-Moiz-Ali wants to merge 1 commit into
Syed-Moiz-Ali wants to merge 1 commit into
Conversation
Syed-Moiz-Ali
force-pushed
the
fix/video-player-disposal
branch
from
e17f5d8 to
c96a2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description\n\nWraps the old controller's pause/dispose in \Future.microtask()\ to ensure disposal happens after the current frame's widget tree has fully unmounted the old VideoPlayer widget.\n\n## Fixes\n\nFixes #19 — Crash on Synchronous VideoPlayerController Disposal\n\n## Root Cause\n\n_switchToHq()\ was synchronously calling \oldController?.pause()\ and \oldController?.dispose()\ right after \setState(). Since the widget tree hadn't finished unmounting the old \VideoPlayer\ widget in the same frame, attached listeners (\ValueListenableBuilder) could still trigger updates on the disposed controller, causing an assertion error.