Skip to content

Fix ruby 3.4 warning#11

Open
kzkn wants to merge 2 commits into
win93:developmentfrom
kzkn:fix-ruby-34-warning
Open

Fix ruby 3.4 warning#11
kzkn wants to merge 2 commits into
win93:developmentfrom
kzkn:fix-ruby-34-warning

Conversation

@kzkn

@kzkn kzkn commented Aug 1, 2025

Copy link
Copy Markdown
  • fiddle gem warning
  • frozen string warning

kzkn added 2 commits August 1, 2025 14:30
```
warning: fiddle was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
```

fiddle gem drops ruby <2.5 support at v1.1.0
So specifies the version of fiddle gem as `~> 1.0.9`
@win93

win93 commented Jan 4, 2026

Copy link
Copy Markdown
Owner

For reference, this is the warnings you get without this patch:

.../ruby-xz/lib/xz.rb:314: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)
.../lib/xz.rb:206: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)
.../ruby-xz/lib/xz/stream.rb:115: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)

This fix looks good.

Testing this patch passes on ruby-3.4, but I have latent maintenance work to get GitLab CI working again to test other rubies before I'll merge this PR.

(Apologies for the delay, I found out that GitLab was not emailing me about this project, but I've addressed this problem 😉)

@jer-k

jer-k commented Jan 23, 2026

Copy link
Copy Markdown

The fiddle warning is now a breaking change in Ruby 4.0.0 as noted in #13.

Anything we can do to help here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants