Fix empty group ordering#322
Merged
waynemwashuma merged 3 commits intoMay 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix scheduling behavior for empty system groups by treating them as explicit ordering barriers during graph expansion. This ensures ordering constraints remain valid even when intermediary groups contain no systems.
Solution
Previously, group ordering constraints were expanded directly into system-to-system edges. This worked when groups contained systems, but failed for empty groups because they produced no graph nodes during expansion.
As a result, ordering relationships that depended on empty intermediary phases could silently disappear. This introduces explicit graph nodes for system groups and uses them as ordering barriers when a group has no systems.The new approach preserves ordering semantics regardless of whether a group currently contains systems.Instead of collapsing groups prematurely into systems, the scheduler now treats groups as first-class ordering nodes. This allows:
Showcase
Before
If
MiddlePhasecontained no systems, the ordering relationship could collapse during graph expansion.After
MiddlePhasenow acts as a stable ordering barrier even without systems.Migration guide
No migration required.
Notes
Checklist