Implement nesting in system groups#319
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Introduce hierarchical system groups with inherited ordering constraints in the scheduler.
This adds support for nested system groups, allowing child groups to inherit ordering relationships from parent groups while preserving schedule isolation and cycle safety.
Solution
The scheduler previously treated system groups as flat structures. Ordering constraints applied only to the systems directly registered inside a group, making it difficult to model layered execution phases or reusable scheduling hierarchies.
This introduces explicit parent-child relationships between system groups and expands ordering resolution across descendants.
What changed
parentsupport toSystemGroupConfigparentIdtracking during scheduler buildWhy this approach
Instead of flattening groups eagerly during registration, hierarchy resolution is deferred until schedule construction. This keeps registration lightweight while enabling:
Recursive expansion also ensures that ordering rules defined on high-level phases automatically propagate to deeply nested descendants.
Showcase
Before
nestedwas not affected byRootPhaseordering constraints.After
nestednow inherits the ordering constraints fromRootPhase.Migration guide
No migration required.
Notes
Checklist