Skip to content

Added a Makefile and .gitignore#3

Closed
iamed18 wants to merge 3 commits into
willb:masterfrom
iamed18:master
Closed

Added a Makefile and .gitignore#3
iamed18 wants to merge 3 commits into
willb:masterfrom
iamed18:master

Conversation

@iamed18

@iamed18 iamed18 commented May 17, 2016

Copy link
Copy Markdown

Including a generic Makefile for those that may prefer CLI dissertation-writing as well as a .gitignore for all of the extra compiled files should someone want to directly work on their dissertation in a git repo.

Comment thread .gitignore
*.sql
*.sqlite

# LaTeX Generated Files #

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be much better for this to only exclude temporary files generated by LaTeX. (For example, someone with a sql or sqlite file used to store experiment results and automatically generate figures might be surprised to find it excluded from version control.)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will admit to just including a boilerplate .gitignore that has everything
that I usually don't want to push. Perhaps it isn't the most concise, but I
don't think individuals will have issue with it and could modify to fit
specific use as needed.

Or I could just change it for the pull request :)

On Tue, May 17, 2016 at 5:10 PM Will Benton notifications@github.com
wrote:

In .gitignore
#3 (comment):

+.7z
+
.dmg
+.gz
+
.iso
+.jar
+
.rar
+.tar
+
.zip
+
+# Logs and databases #
+######################
+.log
+
.sql
+*.sqlite
+
+# LaTeX Generated Files #

It would be much better for this to only exclude temporary files generated
by LaTeX. (For example, someone with a sql or sqlite file used to store
experiment results and automatically generate figures might be surprised to
find it excluded from version control.)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/willb/wi-thesis-template/pull/3/files/b9852d04476cd951b43e969e4ba8bbc75b1b6fb1..642934b69daba76b188d9e1687c3895e09617080#r63613389

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: it's not an issue of boilerplate, it's an issue of surprising users who might actually want to commit those things. In general, it's better to tread lightly with default .gitignores. :-)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it up and resubmit. I'm still learning git and this is a wild ride.

On Tue, May 17, 2016 at 5:17 PM Will Benton notifications@github.com
wrote:

In .gitignore
#3 (comment):

+.7z
+
.dmg
+.gz
+
.iso
+.jar
+
.rar
+.tar
+
.zip
+
+# Logs and databases #
+######################
+.log
+
.sql
+*.sqlite
+
+# LaTeX Generated Files #

Yes: it's not an issue of boilerplate, it's an issue of surprising users
who might actually want to commit those things. In general, it's better to
tread lightly with default .gitignores. :-)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/willb/wi-thesis-template/pull/3/files/b9852d04476cd951b43e969e4ba8bbc75b1b6fb1..642934b69daba76b188d9e1687c3895e09617080#r63614272

@willb

willb commented May 17, 2016

Copy link
Copy Markdown
Owner

The .gitignore is welcome (with the suggested changes to the exclusion list). The Makefile is nice but (given the way the project is structured) a little dubious above just using latexmk directly (which is what I did). However, I'm inclined to include it anyway. Commit d5a9ceb and the non-.gitignore part of 642934b don't belong in a PR.

Could you please rebase to single-purpose commits with descriptive names and eliminate the extra additions?

@iamed18

iamed18 commented May 17, 2016

Copy link
Copy Markdown
Author

Closing this one in favor of starting anew. See it here: #4

@iamed18 iamed18 closed this May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants