Add support for aarch64/arm64 architecture#92
Open
Kaweees wants to merge 4 commits into
Open
Conversation
ee35195 to
5841bf8
Compare
fTetWild stores -1 sentinels in std::array<char, 4>. That is only valid when char is signed. The aarch64 ABI defaults char to unsigned, which silently turns those sentinels into 255 and breaks the mesher. Pass -fsigned-char to the compiler on aarch64/arm64 (GCC/Clang) so the existing code keeps working without source changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request adds support for ARM64 and AArch64 Linux
Closes #84 and #39