fix: Correct TypeScript overload signatures in FetchMock.route()#992
Open
MatrixNeoKozak wants to merge 1 commit into
Open
fix: Correct TypeScript overload signatures in FetchMock.route()#992MatrixNeoKozak wants to merge 1 commit into
MatrixNeoKozak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
routemethod inFetchMock.tshas overloaded signatures that accept either a singleUserRouteConfig/RouteConfigWrapperargument or three arguments (matcher, response, options). The third parameteroptionsis typed asUserRouteConfig | RouteConfigWrapper | string, which matches the provided argument types. However, the implementation uses@ts-expect-errorcomments to suppress TypeScript errors when callingthis.route(...)from shorthand methods. This change removes the@ts-expect-errorcomments and adjusts the overloaded implementation signature to be more precise, ensuring that TypeScript can correctly type-check the internal calls. The fix aligns the implementation with the declared overloads and improves type safety without altering runtime behavior.