Skip to content

Editorial: Add missing comma in argument list#9888

Closed
networkException wants to merge 1 commit into
whatwg:mainfrom
networkException:fix-missing-comma-in-args-list
Closed

Editorial: Add missing comma in argument list#9888
networkException wants to merge 1 commit into
whatwg:mainfrom
networkException:fix-missing-comma-in-args-list

Conversation

@networkException

@networkException networkException commented Oct 28, 2023

Copy link
Copy Markdown

This pull request fixes a missing comma in the arguments list for calling fetch a single imported module script in HostLoadImportedModule.

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/webappapis.html ( diff )

This patch fixes a missing comma in the arguments list for calling
fetch a single imported module script in HostLoadImportedModule.
@linusg linusg added topic: script editorial Changes that do not affect how the standard is understood labels Oct 28, 2023
@Ms2ger

Ms2ger commented Oct 30, 2023

Copy link
Copy Markdown
Member

Also fixed in #9872

@annevk annevk closed this in 3fa726a Oct 30, 2023
@annevk

annevk commented Oct 30, 2023

Copy link
Copy Markdown
Member

Thank you @networkException. I ended up taking @Ms2ger's PR for this. Hope that's okay.

@networkException

Copy link
Copy Markdown
Author

Yep of course, just glad its fixed :^)

lozy219 pushed a commit to lozy219/html that referenced this pull request Mar 10, 2025
In particular:

* Give script's settings object an ID and data-x.
* Note that a script's fetch options can be null.
* Correct miscount in definition of 'script'. This was introduced in 3d45584 (whatwg#4898).
* Fix typos in HostLoadImportedModule.

Fixes whatwg#9867 and closes whatwg#9888.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial Changes that do not affect how the standard is understood topic: script

Development

Successfully merging this pull request may close these issues.

4 participants