Integrate with MakeRealm#12580
Draft
annevk wants to merge 3 commits into
Draft
Conversation
Initial attempt at integrating with tc39/ecma262#3728.
| <dd> | ||
| <p>Return <var>execution context</var>.</p> | ||
| </dd> | ||
| <dd><p>Return the <span>JavaScript execution context</span> whose Realm component is |
Member
There was a problem hiding this comment.
Getting the execution context in this way does make MakeRealm nicer, but I find it unfortunate that "realm execution context" is now less defined since there can be javascript execution contexts with the same realm components (and entry realm being defined relative to this). I was wondering here whether this algorithm should take an execution context as an argument (and extract the realm from there). Unfortunately this does go against the layering desired in tc39/ecma262#3728 though by instead doing EC into realm creation
Member
Author
There was a problem hiding this comment.
Probably need input from @jmdyck and @nicolo-ribaudo on this. I don't have strong opinions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt at integrating with tc39/ecma262#3728.
This should be editorial.
/browsers.html ( diff )
/document-lifecycle.html ( diff )
/document-sequences.html ( diff )
/imagebitmap-and-animations.html ( diff )
/infrastructure.html ( diff )
/nav-history-apis.html ( diff )
/webappapis.html ( diff )
/workers.html ( diff )
/worklets.html ( diff )