Handle media <source> moves around the pointer#12511
Open
zcorpan wants to merge 3 commits into
Open
Conversation
Also define the logic in terms of two variables instead of nodes before and after pointer. Fixes #12500
Member
Author
annevk
reviewed
Jun 4, 2026
| has a next sibling, then set <var>pointerAfter</var> to that sibling; otherwise, set | ||
| <var>pointerAfter</var> to null.</p> | ||
|
|
||
| <p>As nodes are <span data-x="concept-node-insert-ext">inserted</span>, <span |
Member
There was a problem hiding this comment.
We have test coverage here for arbitrary nodes? Surprised we don't use source element insertion/removal/moving steps.
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Yes I was thinking also we should switch to tracking only the source children, but it's a slightly larger leap for the spec. There are tests at https://wpt.fyi/results/html/semantics/embedded-content/media-elements/loading-the-media-resource?label=experimental&label=master&aligned
annevk
approved these changes
Jun 5, 2026
nicolo-ribaudo
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also define the logic in terms of two variables instead of nodes before and after pointer.
Fixes #12500
(See WHATWG Working Mode: Changes for more details.)
/media.html ( diff )