Use the value attribute for color update if dirty value flag is false#12065
Conversation
|
Do I now need to do something to trigger preview, or the bot is misbehaving? Hmm. (#12069 isn't getting preview either, so not just this one) |
annevk
left a comment
There was a problem hiding this comment.
The wording of that step feels a tad ambiguous. Perhaps it's better to make it two steps?
I made it two paragraphs in one step, as it seems it's sufficiently common in HTML to do so. There are a few instances of separate-step usage too, so either way is okay for me but I thought this could feel a bit more natural. |
|
It seems this fails on CI. Modern style doesn't do initialization of a variable twice so that needs to be done differently. |
You mean merge it back? |
|
Sorry for forgetting about this, this is what I would do: <li>
<p>Let <var>value</var> be the result of running these steps:
<ol>
<li><p>If <var>element</var>'s <span data-x="concept-fe-dirty">dirty value flag</span> is true,
then return the result of running <span>get an attribute by name</span> given "<code
data-x="">value</code>" and <var>element</var>.</p></li>
<li><p>Return <var>element</var>'s <span data-x="concept-fe-value">value</span>.</p></li>
</ol>
</li> |
|
Interesting, never heard of returning inside another algorithm. Works for me! |
Fixes #12057
(See WHATWG Working Mode: Changes for more details.)
/common-dom-interfaces.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )