Skip to content

Use the value attribute for color update if dirty value flag is false#12065

Merged
annevk merged 7 commits into
whatwg:mainfrom
saschanaz:value-attr-color
Jan 14, 2026
Merged

Use the value attribute for color update if dirty value flag is false#12065
annevk merged 7 commits into
whatwg:mainfrom
saschanaz:value-attr-color

Conversation

@saschanaz

@saschanaz saschanaz commented Jan 8, 2026

Copy link
Copy Markdown
Member

Fixes #12057

  • At least two implementers are interested (and none opposed):
    • WebKit (already implemented)
    • Gecko
  • Tests are written and can be reviewed and commented upon at:
    • WPT already expects this
  • Implementation bugs are filed:
    • Chromium: (the attributes are not implemented there yet)
    • Gecko: Will be part of https://bugzilla.mozilla.org/show_bug.cgi?id=1919718
    • WebKit: N/A
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): N/A
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): N/A
  • Corresponding HTML AAM & ARIA in HTML issues & PRs: N/A
  • MDN issue is filed: N/A?
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/common-dom-interfaces.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )

@saschanaz

saschanaz commented Jan 9, 2026

Copy link
Copy Markdown
Member Author

Do I now need to do something to trigger preview, or the bot is misbehaving? Hmm.

(#12069 isn't getting preview either, so not just this one)

@saschanaz saschanaz requested a review from annevk January 9, 2026 10:33

@annevk annevk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording of that step feels a tad ambiguous. Perhaps it's better to make it two steps?

Comment thread source Outdated
Comment thread source Outdated
Comment thread source Outdated
Comment thread source Outdated
@saschanaz

Copy link
Copy Markdown
Member Author

The wording of that step feels a tad ambiguous. Perhaps it's better to make it two steps?

I made it two paragraphs in one step, as it seems it's sufficiently common in HTML to do so. There are a few instances of separate-step usage too, so either way is okay for me but I thought this could feel a bit more natural.

@annevk

annevk commented Jan 9, 2026

Copy link
Copy Markdown
Member

It seems this fails on CI. Modern style doesn't do initialization of a variable twice so that needs to be done differently.

@saschanaz

Copy link
Copy Markdown
Member Author

Modern style doesn't do initialization of a variable twice so that needs to be done differently.

You mean merge it back?

@annevk

annevk commented Jan 13, 2026

Copy link
Copy Markdown
Member

Sorry for forgetting about this, this is what I would do:

   <li>
    <p>Let <var>value</var> be the result of running these steps:

    <ol>
     <li><p>If <var>element</var>'s <span data-x="concept-fe-dirty">dirty value flag</span> is true,
     then return the result of running <span>get an attribute by name</span> given "<code
     data-x="">value</code>" and <var>element</var>.</p></li>
     
     <li><p>Return <var>element</var>'s <span data-x="concept-fe-value">value</span>.</p></li>
    </ol>
   </li>

@saschanaz

Copy link
Copy Markdown
Member Author

Interesting, never heard of returning inside another algorithm. Works for me!

@annevk annevk merged commit 74cbe0a into whatwg:main Jan 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

"update a color well control color" works based on the input value concept while WPT expects the value attribute

2 participants