-
Notifications
You must be signed in to change notification settings - Fork 34
Fix emotion calculation and enhance island supply logic #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0298548
fix(island): 修复 岛屿-每日补给/珍珠采购 在较慢的设备上工作不正常的问题
yyjdelete 399f6c5
feat(cdn): 添加站点 URL 处理和生成站点地图与 robots.txt
7b8ba16
fix(emotion,coalition): 修复情绪计算和联盟沉船心情扣减逻辑
Beatrice-betty 5213d20
fix(emotion,coalition): 修复情绪计算和联盟沉船心情扣减逻辑 (#641)
wess09 4a83630
fix(island): 修复 岛屿-每日补给/珍珠采购 在较慢的设备上工作不正常的问题 (#638)
wess09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): 需要防止 GOC_MIRROR_URLS 中的非法 URL 导致构建崩溃。
uniqueUrls当前会调用normalizeSiteUrl,而后者内部执行new URL(...)。任何在GOC_MIRROR_URLS中的非法值都会抛出异常并终止构建。由于这一配置来自用户/环境变量,建议在这里做防御性处理(例如在uniqueUrls中用 try/catch 记录日志并跳过非法条目,或者在parseUrlList中先做合法性校验再归一化),以避免单个错误 URL 就导致整个构建失败。Original comment in English
issue (bug_risk): Guard against invalid URLs in GOC_MIRROR_URLS crashing the build.
uniqueUrlscurrently callsnormalizeSiteUrl, which doesnew URL(...). Any malformed value inGOC_MIRROR_URLSwill throw and terminate the build. Since this comes from user/env config, consider handling this defensively (e.g. try/catch inuniqueUrlswith logging + skipping invalid entries, or validating inparseUrlListbefore normalization) so a single bad URL doesn’t fail the entire build.