Skip to content

fix(island): 修复 岛屿-每日补给/珍珠采购 在较慢的设备上工作不正常的问题#638

Open
yyjdelete wants to merge 1 commit into
wess09:devfrom
yyjdelete:dev
Open

fix(island): 修复 岛屿-每日补给/珍珠采购 在较慢的设备上工作不正常的问题#638
yyjdelete wants to merge 1 commit into
wess09:devfrom
yyjdelete:dev

Conversation

@yyjdelete

@yyjdelete yyjdelete commented Jul 26, 2026

Copy link
Copy Markdown
Contributor
  1. 每日补给合并为使用珍珠采购中的逻辑进入离开好友岛屿, 修复进入较慢时的Too many click报错;
  2. 访问岛屿添加1s的二次状态检测, 避免加载过程中UI一闪而过时, 被误识别为进入, 同时确保岛屿状态稳定, 避免后续移动丢失;
  3. 退出好友岛屿的检测条件ISLAND_ACCESS_MAP(好友岛屿)->ISLAND_GOTO_MAP(自己岛屿), 超时时间20->30s;
  4. 在地图切换成功、补给领取、打开珍珠售卖之后添加额外的等待, 确保状态稳定,避免吞后续触控操作;
  5. minitouch的drag_minitouch(): 还原疑似在feat : IsLand 岛屿全部重构 #218, Refactor island configuration and management with localization updates #228 中被误删除的的触摸抬起;
    之前提交的diff
  6. minitouch的island_swipe_hold_minitouch(): 合并builder.wait(hold_time)到前一次操作, 避免重复打印Command list empty, sending it may cause unexpected behaviour: w {hold_time}的警告

Summary by Sourcery

在每日补给和珍珠购买流程中统一好友岛屿的进入与退出逻辑,并加入更严格的状态检查和等待机制,以提升在低性能设备上的可靠性。

New Features:

  • 引入共享的好友岛屿访问辅助方法,在继续执行操作前先验证场景是否完全加载。

Bug Fixes:

  • 修复好友岛屿进入与退出检测不稳定的问题,该问题会在低性能设备上导致超时、错误地将问题归类为访问错误,以及触控操作被吞掉。
  • 恢复在 minitouch 拖拽操作中的缺失“触控释放”动作,防止滑动操作卡住或表现不一致。
  • 移除多余的 minitouch 滑动按住命令,避免触发“Command list empty”警告。

Enhancements:

  • 在岛屿地图切换、每日补给交互以及珍珠交易对话框周围加入二次状态校验和更长的超时时间,确保在执行后续操作前 UI 状态稳定。
Original summary in English

Summary by Sourcery

Unify friend island visit and exit logic across daily supply and pearl purchasing flows, adding more robust state checks and waits to improve reliability on slower devices.

New Features:

  • Introduce a shared friend island visit helper that validates full scene load before proceeding.

Bug Fixes:

  • Fix unreliable friend island entry and exit detection that caused timeouts, misclassification of access errors, and swallowed touch actions on slower devices.
  • Restore missing touch release in minitouch drag operations to prevent stuck or inconsistent swipe behaviour.
  • Eliminate redundant minitouch swipe hold commands that triggered "Command list empty" warnings.

Enhancements:

  • Add secondary state verification and extended timeouts around island map transitions, daily supply interactions, and pearl trade dialogs to ensure UI stability before subsequent actions.

@sourcery-ai

sourcery-ai Bot commented Jul 26, 2026

Copy link
Copy Markdown

🧙 Sourcery 已完成对你的拉取请求的审查!


提示与命令

与 Sourcery 交互

  • 触发新的审查: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 从审查评论生成 GitHub issue: 通过回复某条审查评论,请 Sourcery 从该评论创建一个 issue。你也可以在审查评论下回复 @sourcery-ai issue 来从该评论创建一个 issue。
  • 生成拉取请求标题: 在拉取请求标题的任意位置写上 @sourcery-ai,即可随时生成标题。你也可以在拉取请求中评论 @sourcery-ai title,在任意时刻(重新)生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任意位置写上 @sourcery-ai summary,即可在你想要的位置随时生成 PR 摘要。你也可以在拉取请求中评论 @sourcery-ai summary,在任意时刻(重新)生成摘要。
  • 生成审查者指南: 在拉取请求中评论 @sourcery-ai guide,即可在任意时刻(重新)生成审查者指南。
  • 解决所有 Sourcery 评论: 在拉取请求中评论 @sourcery-ai resolve,即可解决所有 Sourcery 评论。如果你已经处理完所有评论且不想再看到它们,这会非常有用。
  • 撤销所有 Sourcery 审查: 在拉取请求中评论 @sourcery-ai dismiss,即可撤销所有现有的 Sourcery 审查。特别适用于希望从头开始新的审查——别忘了评论 @sourcery-ai review 来触发新的审查!

自定义你的使用体验

打开你的控制面板以:

  • 启用或禁用审查功能,例如 Sourcery 生成的拉取请求摘要、审查者指南等。
  • 更改审查语言。
  • 添加、删除或编辑自定义审查说明。
  • 调整其他审查设置。

获取帮助

Original review guide in English

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我留下了一些总体反馈:

  • find_air_drop 中,由于在成功执行 check_visit_friend_island 后会立即 return Truehas_clickable_air_drop 标志现在已经变得多余;你可以通过移除这个标志和后续的检查来简化逻辑。
  • 新增的若干 sleep 调用(例如围绕进入地图、空投点击以及交易对话框的固定 0.5 秒/1 秒等待)目前是硬编码的;建议将这些延迟集中管理,或者基于明确的 UI 状态检查来控制,以避免到处都是魔法数字,并使在慢设备上的调优更加容易。
面向 AI 代理的提示
Please address the comments from this code review:

## Overall Comments
- In `find_air_drop`, the `has_clickable_air_drop` flag has become redundant now that you `return True` immediately after a successful `check_visit_friend_island`; you can simplify the logic by removing the flag and the follow‑up check.
- Several new `sleep` calls (e.g., fixed 0.5s/1s waits around map entry, air drop clicks, and trade dialogs) are hardcoded; consider centralizing these delays or basing them on explicit UI state checks to avoid scattered magic numbers and make tuning for slow devices easier.

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助,请考虑分享它 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English

Hey - I've left some high level feedback:

  • In find_air_drop, the has_clickable_air_drop flag has become redundant now that you return True immediately after a successful check_visit_friend_island; you can simplify the logic by removing the flag and the follow‑up check.
  • Several new sleep calls (e.g., fixed 0.5s/1s waits around map entry, air drop clicks, and trade dialogs) are hardcoded; consider centralizing these delays or basing them on explicit UI state checks to avoid scattered magic numbers and make tuning for slow devices easier.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `find_air_drop`, the `has_clickable_air_drop` flag has become redundant now that you `return True` immediately after a successful `check_visit_friend_island`; you can simplify the logic by removing the flag and the follow‑up check.
- Several new `sleep` calls (e.g., fixed 0.5s/1s waits around map entry, air drop clicks, and trade dialogs) are hardcoded; consider centralizing these delays or basing them on explicit UI state checks to avoid scattered magic numbers and make tuning for slow devices easier.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant