feat: auto config for vttablet#589
Draft
earayu wants to merge 5 commits into
Draft
Conversation
earayu
force-pushed
the
simplify_config
branch
from
November 28, 2024 03:07
a9a77a3 to
70f4b60
Compare
earayu
force-pushed
the
simplify_config
branch
from
December 6, 2024 07:48
70f4b60 to
198f6de
Compare
earayu
force-pushed
the
simplify_config
branch
from
December 18, 2024 09:12
198f6de to
5344137
Compare
earayu
marked this pull request as ready for review
December 18, 2024 11:56
newborn22
reviewed
Dec 18, 2024
| if err != nil { | ||
| log.Exitf("failed to parse --tablet-path: %v", err) | ||
|
|
||
| config, mycnf := initConfig(tabletAlias) |
Collaborator
There was a problem hiding this comment.
when *topodatapb.TabletAlias is nil , it may casue NullPointerException in initConfig(tabletAlias)
earayu
marked this pull request as draft
December 19, 2024 01:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s) & Descriptions
Checklist