Skip to content

fix: resume generation from quality v2 records - #18

Merged
wenn-id merged 1 commit into
mainfrom
fix/v2-quality-resume-cache
Jul 31, 2026
Merged

fix: resume generation from quality v2 records#18
wenn-id merged 1 commit into
mainfrom
fix/v2-quality-resume-cache

Conversation

@wenn-id

@wenn-id wenn-id commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • read generation dependencies from schema 2.0 panel QA bindings
  • preserve schema 1.0 compatibility
  • keep existing generation cache reusable when evidence migrates without dependency changes

Root cause

The panel validator accepted schema 2.0 records, but resume-plan still read only schema 1.0 top-level fields. Valid migrated records therefore produced stage inputs are unavailable: ValueError and incorrectly requested panel regeneration.

Verification

  • RED reproduced the exact regenerate / ValueError failure
  • focused regression passes
  • resume suite: 48 passed
  • full suite: 344 passed, 1 skipped
  • real Batch A probe changes generation from incorrect regenerate to reuse
  • distribution + clean-install contracts pass
  • wheel clean-install base and MCP smokes pass

Summary by CodeRabbit

  • Bug Fixes
    • Improved resume support for both current and legacy panel QA records.
    • Preserved generation-stage cache reuse when resuming from current-format records.
    • Continued enforcing panel matching and dependency validation.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9dea4192-a9de-429c-9d6c-f565e566e981

📥 Commits

Reviewing files that changed from the base of the PR and between f46bcfa and ff5a4d6.

📒 Files selected for processing (2)
  • scripts/comic_sol.py
  • tests/test_resume.py

📝 Walkthrough

Walkthrough

The resume flow now parses schema 2.0 panel QA records alongside legacy records. It validates panel IDs and reuses generation-stage cache entries when prompt and reference bindings match.

Changes

Resume Schema Support

Layer / File(s) Summary
QA dependency parsing
scripts/comic_sol.py, tests/test_resume.py
Schema 2.0 records use subject_id and bindings. Legacy records retain their existing fields. Tests verify generation-stage cache reuse across both schemas.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the fix for resuming generation from schema v2 quality records.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v2-quality-resume-cache

Comment @coderabbitai help to get the list of available commands.

@wenn-id
wenn-id merged commit 059b125 into main Jul 31, 2026
8 checks passed
@wenn-id
wenn-id deleted the fix/v2-quality-resume-cache branch July 31, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant