Establish Comic Sol Lab as canonical public repository - #13
Conversation
🔍 WarpFix PR Review
📖 WalkthroughThe changes include modifications to the GitHub Actions workflow to restrict CI to the 📁 File Changes
⏱ Review Effort & Risk
Risk Factors
Labels: 💡 Key Observations
🤖 Reviewed by WarpFix — AI-Powered Code Review + CI Repair · Security |
| @@ -2,9 +2,8 @@ name: Tests | |||
|
|
|||
| on: | |||
| push: | |||
There was a problem hiding this comment.
logic
Restricting the workflow to only the 'main' branch may prevent testing on other branches that could be important for development.
| push: | |
| Consider adding other branches back to the workflow if they are actively used. |
🤖 WarpFix
| Use Python 3.11 and the pinned dependencies: | ||
|
|
||
| ```bash | ||
| python3.11 -m venv .venv |
There was a problem hiding this comment.
✨ Praise documentation
Great job outlining the development setup clearly, including the use of a virtual environment.
🤖 WarpFix
| python3.11 -m comic_sol_product.release dist/*.whl dist/*.tar.gz | ||
| ``` | ||
|
|
||
| Changes to packaging, runtime freezing, MCP, release automation, or distribution must also pass clean-install and portable-runtime smoke tests. Visual output changes require an actual before/after render and visual inspection; green geometry tests alone are insufficient. |
There was a problem hiding this comment.
documentation
The instructions for running tests could benefit from specifying the expected output or behavior.
| Changes to packaging, runtime freezing, MCP, release automation, or distribution must also pass clean-install and portable-runtime smoke tests. Visual output changes require an actual before/after render and visual inspection; green geometry tests alone are insufficient. | |
| Add a note about what passing tests should look like. |
🤖 WarpFix
| - Target `main`. | ||
| - Explain user-visible behavior and migration impact. | ||
| - Add or update deterministic tests for behavior changes. | ||
| - Preserve the exact 17-tool MCP surface unless a separately reviewed contract change explicitly updates it. |
There was a problem hiding this comment.
documentation
The requirement for visual inspection of changes is good, but it may be too vague for contributors.
| - Preserve the exact 17-tool MCP surface unless a separately reviewed contract change explicitly updates it. | |
| Provide examples of what constitutes sufficient visual inspection. |
🤖 WarpFix
| @@ -6,6 +6,10 @@ invocation drives planning, character consistency, image generation, visual QA, | |||
| selective repair, deterministic lettering and composition, and PDF export. It is | |||
| not a web app or hosted product. No build service is required. | |||
There was a problem hiding this comment.
✨ Praise documentation
Excellent addition of the canonical repository link, which clarifies the project's home.
🤖 WarpFix
| is the canonical, independent home of Comic Sol. New development, issues, pull | ||
| requests, documentation, and releases happen here. | ||
|
|
||
| ## Install |
There was a problem hiding this comment.
documentation
The clone command should specify the correct repository to avoid confusion.
| ## Install | |
| Ensure the command reflects the canonical repository: `git clone https://github.com/wenn-id/comic-sol-lab.git`. |
🤖 WarpFix
|
|
||
| - affected version or commit; | ||
| - reproduction steps and impact; | ||
| - operating system and installation method; |
There was a problem hiding this comment.
🚨 Critical security
The document should emphasize the importance of not including live secrets when reporting vulnerabilities.
| - operating system and installation method; | |
| Add a clear statement at the beginning of the section about the handling of sensitive information. |
🤖 WarpFix
| Do not include live secrets. Revoke exposed credentials before reporting and replace values with `[REDACTED]`. | ||
|
|
||
| ## Scope | ||
|
|
There was a problem hiding this comment.
✨ Praise security
The detailed reporting structure for vulnerabilities is well thought out and comprehensive.
🤖 WarpFix
| @@ -949,6 +949,17 @@ def test_readme_is_judge_runnable_without_a_build_service(self): | |||
| self.assertIn(required, readme) | |||
| self.assertNotRegex(readme.lower(), r"npm run|start the server|docker compose") | |||
|
|
|||
There was a problem hiding this comment.
✨ Praise testing
The test for verifying the canonical repository link is a great addition to ensure documentation accuracy.
🤖 WarpFix
| self.assertNotRegex(readme.lower(), r"npm run|start the server|docker compose") | ||
|
|
||
| def test_public_surface_uses_the_canonical_independent_repository(self): | ||
| readme = self.readme() |
There was a problem hiding this comment.
testing
Ensure that the test for the workflow file checks for all relevant branches, not just the main branch.
| readme = self.readme() | |
| Consider adding assertions for any other branches that should be included. |
🤖 WarpFix
Summary
wenn-id/comic-sol-labas Comic Sol's canonical independent public homemainthe only canonical push CI branchVerification