issue-45 exop - #49
Open
the-red-paintings wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@sobolevn, please review |
sobolevn
reviewed
Jun 26, 2019
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
Thanks for you work! Can you please explain what has changed in the library?
And what are other solutions to fix the upgrade?
| alias Kira.Repo | ||
|
|
||
| parameter(:issue_uid, type: :integer) | ||
| parameter(:project_uid, type: :integer, required: false) |
Member
There was a problem hiding this comment.
Why do we need all these params? What has changed in the library?
|
|
||
| parameter(:issue_uid, type: :integer) | ||
| parameter(:project_uid, type: :integer, required: false) | ||
| parameter(:issue_uid, type: :integer, required: true) |
Member
There was a problem hiding this comment.
Only issue_uid is used directly. Other params are unused.
| @bot_username "@kira-bot" | ||
|
|
||
| parameter(:note_text, type: :string) | ||
| parameter(:project_uid, type: :integer, required: false) |
Member
There was a problem hiding this comment.
The same here. Why do we need al of them when we only use note_text?
Contributor
Author
Contributor
Author
|
Since 1.3 exop had breaking changes for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issues
Refs #45