Allow views arguments to be unset#5
Open
seanbeaton wants to merge 2 commits into
Open
Conversation
Absorbed the following functions into the class: - viewfield_element_info() - viewfield_pre_render() - viewfield_post_render() - _viewfield_get_view_args() -- This was made getViewArgs() which is a protected method Left rendering for the theme.
… the arguments from the path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on marcus-n3rd's fork to allow view arguments to be unset. Before, if you didn't provide them when referencing the view, it would pass an empty array as the arguments, instead of not passing them at all. This would stop you from taking the arguments from somewhere else, for example, the path.
This should be pulled after PR 4: #4