Adding cache tags

[luksak]

I added cache tags. This needs tests.

[Berdir]

Should also include cache contexts and max-age. Try using something like CacheableMetadata::createFromObject($view)->applyTo($build);

[Berdir]

That said, a lot here looks unported. the #type there doesn't do anyting because it has not been ported, so the only reason it does something at all is because the code additionally also hardcodes the #theme.

I would recommend to build the initial render array like this:

$view = Views::getView('view_id');
$build = $view->buildRenderable('display', $arguments)

the argument parsing logic would have to change from a pre render callback to be done in the formatter. IMHO, that would be much easier to follow & understand.

If necessary, the template could be kept as a wrapper template around the view.

[luksak]

Alright, tried to implement this. Does this look right? Is the usage of _viewfield_get_view_args() ok inside ViewfieldDefaultFormatter?

[luksak]

After updating core and contrib i kept getting this error:

Warning: array_flip(): Can only flip STRING and INTEGER values! in Drupal\Core\Entity\EntityStorageBase->loadMultiple() (line 227 of core/lib/Drupal/Core/Entity/EntityStorageBase.php).Warning: array_flip(): Can only flip STRING and INTEGER values! in Drupal\Core\Entity\EntityStorageBase->loadMultiple() (line 227 of core/lib/Drupal/Core/Entity/EntityStorageBase.php).

Switching back to my original approach solved it. Any idea why this happens?

[marcus-n3rd]

@luksak , by "Switching back to my original approach solved it," do you mean reverting ce911e4? Because I ran into a problem with using my fork where new content does not invalidate the node containing the viewfield. Once I added cache tags like in e45a3a6, it worked perfectly. (FYI the site's core is 8.1.8)