Sync with upstream#46
Open
github-actions[bot] wants to merge 501 commits into
Open
Conversation
Bug: T293512 Change-Id: Ib4ed55cc5134dcfdea4b2251ac21d55969427b43
Bug: T343839 Change-Id: Ic4608e37434f756a1b60b4722036be4cc27a3b4a
Change-Id: I874603bcb4db7c36b77aa8b6c91c584f604db0a5
Change-Id: I42f780f434cdc78301cf4ffb30d8ea7ec4bc941b
Same idea as what 57e44ef did for the server-side code, but for the client-side code this time. You can tweak the `$sections = ...` line in Hooks.php to test this on various skins. Everything works on any skin I tried with the "all" notifications badge enabled, except that the skins don't have any styles for that badge. Change-Id: I7dd8b94e8e24d0237a5ef9258bc0a27ee5e06a13
The user's notification "seen time" is not stored in user preferences since 35c4a37 (2015). Change-Id: I8fc5860c4df31ba3fce8b1e11183e3eeafa90cfb
The same value is already the default in SeenTime::getTime() when the last seen time is not set. Change-Id: I26abd0ad883c5729e63f68d41631bc7c4ea50e7c
They currently use a pattern like 'echo-category-title-<category>'. These days we prefer message names to be explicit rather than dynamic: https://www.mediawiki.org/wiki/Manual:Coding_conventions#Dynamic_identifiers Category tooltip messages already could be defined by the extension, so implement the addition in a similar manner. Change-Id: I8dccfb97bc2de54b6df9c569d2488a956605a76c
These messages add nothing over the category titles. Remove them, because the list of notification preferences is already very busy, especially with some extensions installed. Change-Id: I6951805a6a0157af069a0060f768f9b48970b6e3
Change-Id: I4d8e1e2e1273c4a4d971c6fe543ca93b3aa5ab00
Change-Id: Ifa1542e18c5ded8b977974e6454fbb4630002b81
Add extension attributes corresponding to the $wgEchoNotifications, $wgEchoNotificationCategories and $wgEchoNotificationIcons globals, so that other extensions don't need to use the BeforeCreateEchoEvent hook to modify those globals. Bug: T394565 Change-Id: I29f5c207917b8bcfda1fad70a734a2f8a525f1c3
Change-Id: Ic7e340424cc4bf862ceec9a404ba9f199239b71b
Change-Id: I5568f7cb5e4d4243fef98b2411459e96e14a8b92
Register a notification handlers for MediaWiki's simple notification and display the given message with no adornments. Bug: T385839 Change-Id: I4dd80807cc6371446ab11257c127d3630c1aaed4
Change-Id: Ibb108c9bc2c95ac521f9fa9ee3ec25827b0d7fed
Change-Id: I3bc9878f517d315076c8a07cf5eeb5d87e482ad9
Change-Id: I0e69cd889d796cd7e4a470e2b169444f335f1b99
Why: - testSigningDetection() currently fails when run in isolation, because the test case "Bug: T87852" relies on testGenerateEventsForRevision() having prewarmed the Title::newFromText() cache with a Title instance for the user page of the user being tested. - This is because the latter test correctly mocks the content language code, while the former does not. What: - Allow testSigningDetection() to override the language code. Bug: T395214 Change-Id: Ic35b45015ff5a53f6e728b69b59cc57efe0b390b
To simplify and also unify the Echo and MediaWiki notification system lets introduce a second, optional pareter `RecipientSet $recipients`. This will allow extension developers to easily provide list of Event recipients without having to worry about UserLocators. Additionally this will unify the Event::create() signature with NotificationService which will allow us to easily migrate from one to another. Bug: T395056 Change-Id: I3f3a08b4659a05ab7c29d51f78d7d4f9075d430f
Change-Id: Ieabc66ef5285464e4a619d0b98029eec805d9ef9
Change-Id: I19e5012d4b6ff812632fc22f8e6b8ffddec38642
Change-Id: I72648439b9488fd96052057214b1a8961dad8ed3
Why - $1 should not be shown to the user. That's supposed to be substituted with something else. What - Instead of showing "You don't have permission to $1.", show "You don't have permission to read your notifications." Testing plan - Copy paste the changed code to the first line of ApiEchoNotifications->execute(), so that you can see what it renders. - Visit http://localhost:8080/w/api.php?action=query&format=json&meta=notifications to see the error message. Bug: T421991 Bug: T420154 Change-Id: Iecb8a01b35260d98209061df4a821e3b2231b585 (cherry picked from commit ce8a198)
Bug: T422218 Change-Id: Iaa6d03afc60d33c92e18a66f3b42567e7e1fd3fb (cherry picked from commit 23fb2d0)
…ternally Same change as I44fb7f76f2e66f88b89c3662478bf13eac39a36b in CheckUser. Change-Id: I0faf859e7e7beac98c790bf6589e6cfa0b7ae7da (cherry picked from commit cd17898)
API clients generally authenticate using either OAuth or bot password. Both of those auth mechanisms require its owner to define what grants will it have access to. This is necessary to allow tools to access notifications via an OAuth token or a bot password. I originally considered (re)using the private-information grant (coming from core), but then I decided I probably won't want to give my email address to any tool that needs my notifications, so I created a separate grant. Bug: T420154 Change-Id: I6490d0a6b42af2fe3afcdd2cb5c054e3bf2bbd40 (cherry picked from commit 27b1ddb)
…g API internally" This reverts commit 2ff3403. Reason for revert: Not needed Change-Id: Ib993cae0efb79bb5e96611aeb4255089ce3b3e97
* GHSA-6v7q-wjvx-w8wg Change-Id: I0dfda48f35f71f4ac17ce915cd96f5ea6ba54182
… and splice in @typescript-eslint/eslint-plugin (already provided by eslint-config-wikimedia) because npm is a distaster. Change-Id: I2551f93b6a9cc0ec562d6c107030a9bfe00031e5
Change-Id: Ib9aba310585301f8741d2991bd88309d74600b5b
* grunt: 1.6.1 → 1.6.2 * grunt-legacy-log: 3.0.0 → 3.0.1 * GHSA-f23m-r3pf-42rh * GHSA-r5fr-rjxr-66jc * grunt-legacy-util: 2.0.1 → 2.0.2 * GHSA-f23m-r3pf-42rh * GHSA-r5fr-rjxr-66jc * lodash: 4.17.23 → 4.18.1 * GHSA-f23m-r3pf-42rh * GHSA-r5fr-rjxr-66jc Change-Id: Ideca343bb5c31c5e43deb9615557bd94ad6c3196
* GHSA-rp42-5vxx-qpwr Change-Id: Iff805eb546660b95a5d404e660e68f3bce0a6cd5
* GHSA-gh4j-gqv2-49f6 Change-Id: I6824ee5990321cf566960213c226093602d3dd38
Change-Id: I0268013df6a4afcf77e1a2a2768b88a7cdb626aa
* GHSA-qx2v-qp2m-jg93 Change-Id: I5b3685d2cc88812728a4af731c0ff59dbe3bfde5
Change-Id: Iab2dcfd32fdcf8c72fe49e14981b318e46ecf2b8
Change-Id: I3b15235a4c8f8677da8cce3cbe082af335ec6689
* basic-ftp: 5.3.0 → 5.3.1 * GHSA-rpmf-866q-6p89 * brace-expansion: 1.1.13, 2.0.3, 2.1.0, 5.0.5 → 1.1.13, 2.0.3, 2.1.0, 5.0.6 * GHSA-jxxr-4gwj-5jf2 * fast-uri: 3.0.5 → 3.1.2 * GHSA-q3j6-qgpj-74h6 * GHSA-v39h-62p7-jpjc * fast-xml-builder: 1.1.5 → 1.2.0 * GHSA-45c6-75p6-83cc * GHSA-5wm8-gmm8-39j9 * ip-address: 9.0.5 → 10.2.0 * GHSA-v2v4-37r5-5v8g * socks: 2.8.5 → 2.8.9 * GHSA-v2v4-37r5-5v8g * ws: 8.18.2 → 8.20.1 * GHSA-58qx-3vcg-4xpx Change-Id: I6121d0d83e7fa31c167aa632ce58ea4f616672ac
Change-Id: I7b4f5608b5af52f773b93b4b97bea3550d7ccbc2
Change-Id: Id416786304f161412f88d71e5e8a4736605fdcd9
Change-Id: Ifebbe36b5b42811baf2732fb4587c7f9fc124963
Change-Id: Ibe5100aeac301f769446417e6759f6db5f3741ad
* esbuild: 0.25.5 → 0.28.1 * GHSA-gv7w-rqvm-qjhr * tsx: 4.20.1 → 4.22.4 * GHSA-gv7w-rqvm-qjhr Change-Id: I35872373d6bb86306007031591a1ca7f0e9fb4f2
Change-Id: I65f7879ae6495f1a8661f8ba53ecc2752246c605
* markdown-it: 14.1.1 → 14.2.0 * GHSA-6v5v-wf23-fmfq * ws: 8.20.1 → 8.21.0 * GHSA-96hv-2xvq-fx4p Change-Id: I97668b2b9a9687b9d48a88e27014c4f72360557a
Change-Id: If168925abc9d5031cfe55b780878599c52d00301
* GHSA-35p6-xmwp-9g52 * GHSA-g8m3-5g58-fq7m * GHSA-hm92-r4w5-c3mj * GHSA-p88m-4jfj-68fv * GHSA-pr7r-676h-xcf6 * GHSA-vmh5-mc38-953g * GHSA-vxpw-j846-p89q Change-Id: I485a62335c207f744529d485b7e8d43c26e96b2a
Change-Id: I28112bd6819905ab077c037931d9540dfd3cd034
Change-Id: I9e06dc206cf959075ac19580d3affc4bc792ffd3
* GHSA-mp7j-qc5w-4988 * GHSA-xv26-6w52-cph6 Change-Id: Ibee3679baec3794428c3a25f06241ee23fe84f80
Change-Id: I0c328ba0089c616bf400dc243e741a1b2b596d1a
* svgo: 3.3.3 → 3.3.4 * brace-expansion: 1.1.13, 2.0.3, 2.1.0, 5.0.6 → 1.1.16, 2.1.2, 5.0.7 * GHSA-3jxr-9vmj-r5cp * fast-uri: 3.1.2 → 3.1.4 * GHSA-4c8g-83qw-93j6 * GHSA-v2hh-gcrm-f6hx * linkify-it: 5.0.1 → 5.0.2 * GHSA-v245-v573-v5vm Change-Id: Ib674bd3ace50d3c055ea753edb19335d2f4f5e0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.