fix: declare MIT license in composer.json - #20
Merged
Conversation
The LICENSE file has shipped since the first commit, but composer.json never declared a `license` key. Packagist reads the license from the composer metadata, so the package was listed as having no license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packagist lists the package as having no license.
The
LICENSEfile (MIT) has been in the repo since the first commit, butcomposer.jsonnever declared alicensekey — and Packagist reads the license from the composer metadata, not from the file on disk.composer.json— add"license": "MIT"CHANGELOG.md— record it under6.0.0-rc.1composer validatepasses.Note: Packagist stores metadata per tag, so previously released versions stay license-less. The listing clears once a tag containing this change is published and Packagist syncs. The SilverStripe 5 line has the same gap and is not touched here.