ci: fail php-qa jobs after 20 minutes instead of riding out a bad runner - #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In run 31094035518 (PR #421), the PHP QA (fluent / PHP 8.3) job took 32 minutes while its 8.4/8.5 siblings finished in ~11.5 min and the base-matrix jobs in ~9 min. Investigation showed nothing wrong with the code or workflow:
The slow job also held its runner slot, queueing
E2E (chromium / tailwind)until it finished and stretching the run to ~39 minutes wall clock.What
Add
timeout-minutes: 20to thephp-qajob — roughly double the healthy fluent duration. A degenerate runner now fails fast instead of burning 3× the minutes; a re-run lands on a fresh runner.