Add PHP test + QA harness (Docker testbed, PHPStan/Rector, CI) - #1
Merged
Conversation
…on CI startup failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stands up the module's PHP test + QA pipeline from the start, modelled on
silverstripe-gridbut trimmed to a unit/sapphire-only module (no webserver, Playwright, JS, or Fluent).What's included
.docker/): php-cli container + MySQL running the module symlinked into a SilverStripe 6recipe-cmstestbed via a Composer path repo. No FrankenPHP/webserver.unit+integrationsuites), PHPStanlevel: max+ 100% type-coverage, a second PHPStan pass pinned to the PHP 8.5 target, and Rector (SS6 rule set).Taskfile.yml:test/analyse/analyse-php85/rector/coverage/coverage-checketc.coverage-check)..github/workflows/ci.yml):static-analysis+php-qamatrix across PHP 8.3/8.4/8.5 (coverage gate on 8.3), plus the Docker Hub mirror action and Dependabot.Task fix surfaced by the harness
GenerateTinyMCECombinedTaskreferenced pre-SS6 TinyMCE FQCNs (SilverStripe\Forms\HTMLEditor\TinyMCE*). SS6 extracted these toSilverStripe\TinyMCE\*(packagesilverstripe/htmleditor-tinymce). This PR adds that dependency, corrects the imports, and adds an integration test proving the task runs. A follow-up static-analysis finding (getScriptURL()requiresTinyMCEConfig) is handled with aninstanceofguard + a covering test.Coverage 100%; all static gates green locally.