Edit tasks with $EDITOR (CLI + TUI) - #109
Open
netikular wants to merge 16 commits into
Open
Conversation
After launching nvim and restoring the terminal, the ratatui Terminal object's back buffer still holds the pre-editor frame. Since Terminal::draw() diffs against the back buffer, it produces an incomplete update — garbling the screen. Fix: set a needs_clear flag in launch_editor() and call terminal.clear() in run() before the next draw, which resets the back buffer and sends a hardware clear to force a full redraw.
Replaces raw crossterm calls with ratatui::restore() + ratatui::try_init() in both editor paths (open_path_in_editor and LaunchEditor). Creates a brand-new Terminal with a clean back buffer instead of relying on partial clearing, which caused stale buffer diffs after editor exit. Also refactors LaunchEditor to delegate terminal handling to run() where the Terminal object is accessible, matching the existing open_path_in_editor pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106
Adds
tuxedo edit NCLI command andETUI keybinding that open a task's raw text in $EDITOR for full editing. Terminal suspend/restore uses ratatui::restore() + ratatui::try_init(). Temp files named*.todo.txtfor syntax highlighting plugins. Existing inline editing (e/i) is untouched.