fix: align certificate types and close gathering state#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align certificate generation types with the supported data-channel-first runtime behavior, and reset
iceGatheringStateafterRTCPeerConnection.close().The runtime rejects string-form certificate algorithms, so the TypeScript declaration now only advertises the supported object form. Closing a peer now clears the cached ICE gathering state back to
new, matching the no-transports state exposed after close.Verification
npm run checknpm run native:check- not applicable; no native source changenpm run build- not applicable; no native or build-system changenpm testnpm run api:checknpm run types:checknpm run e2e:chrome- not applicable; no Chrome/browser interop path changenpm run wpt:selection:checknpm run wpt:smokenpm run wpt:smoke:checknpm run wpt:test/npm run wpt:check:strict- not run locally; full WPT is reserved for conformance validationWPT impact
wpt-manifest.jsonis unchanged.docs/divergences.mdnow documents the object-form-only certificate generation behavior.Browser interoperability
No Chrome E2E behavior or coverage changes.
Notes
No libdatachannel pin, WPT pin, native lifetime, callback-threading, workflow, release, permission, or publication impact.