test: stabilize UDP mux close assertion#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize the UDP mux listener close-delivery regression test for the data-channel-first nonstandard UDP mux path.
The test still verifies that
close()/stop()suppress callbacks after close, but it no longer assumes the pre-close STUN send loop delivers exactly one callback before the close point. On Windows, the existingsendUntilloop can observe more than one valid pre-close callback beforelistener.close()runs.Verification
npm run checknpm run native:check- not applicable; no native source changenpm run build- not applicable; test-only changenpm testnpm run api:check- not applicable; no API surface changenpm run types:check- not applicable; no type changenpm run e2e:chrome- not applicable; no browser interop changenpm run wpt:selection:check- not applicable; no WPT selection changenpm run wpt:smoke- not applicable; no WPT harness or WebRTC facade changenpm run wpt:smoke:check- not applicable; no WPT harness or WebRTC facade changenpm run wpt:test/npm run wpt:check:strict- not run locally; this fixes a pre-WPT local test failure in ConformanceAlso run locally:
node --test --test-timeout=30000 test/nonstandard.test.js,git diff --check.WPT impact
No
wpt-manifest.json, selected WPT result, ordocs/divergences.mdchange.Browser interoperability
No Chrome E2E behavior or coverage change.
Notes
This addresses the manual Conformance failure on
windows-latest / Node 20 / WPT, where the pre-WPTnpm teststep failed because the test asserted total callback count instead of post-close callback stability.