Feature #87 implement request storage - #114
Conversation
| ); | ||
|
|
||
| requestDataStorage.setUserId(userService.getByEmail(email).getId()); |
There was a problem hiding this comment.
setAuthentication method already returns UserDetails. so you can use it for getting user id
There was a problem hiding this comment.
I saw your comment here.
as you know we have a class LoggedInUserDetails on the project (I can have a typo in the class name). So it includes id field as far as I know.
please try to use it
There was a problem hiding this comment.
@hamidsultanzadeh LoggedInUserDetails also doesn't have id field also. Can I set id field in LoggedInUSerDetails?
| void signUpOTPConfirmation(SignUpOTPRequest payload); | ||
|
|
||
| void setAuthentication(String email); | ||
| UserDetails setAuthentication(String email); |
There was a problem hiding this comment.
is that fine for the function with the "setAuthentication" name to return UserDetails and behave like getUserDetails?
| Long userId; | ||
|
|
||
| String userLanguage; | ||
| String langId; |
There was a problem hiding this comment.
Are you sure the "langId" type should be String? Shouldn't we use Long instead of String?
3 participants
I set setAuthentification method return UserDetails but in our we didn't need it. Beacause we need our UserDetails object return id and we will set in our dataStorage but UserDetails doesn't return id(it have only getPassword and getUsername). Because of that I create UserService and get user with getEmail and find id with similar method.