added default language for user - #103
Open
agayevilkin wants to merge 6 commits into
Open
Conversation
agayevilkin
requested review from
ArabkhanDev,
gadirovakhadija and
hamidsultanzadeh
October 15, 2023 09:19
Contributor
There was a problem hiding this comment.
please change package name from userconfig to userConfig
Author
There was a problem hiding this comment.
was changed userconfig to userConfig
gadirovakhadija
approved these changes
Oct 15, 2023
hamidsultanzadeh
requested changes
Oct 16, 2023
|
|
||
| userConfigService.insert(UserConfig.builder() | ||
| .key(DEFAULT_LANGUAGE) | ||
| .value(languageService.getDefaultLanguage().getName()) |
Member
There was a problem hiding this comment.
we need to store ID of the default language here
Author
There was a problem hiding this comment.
added an "entityId" field to UserConfig class and I tested It works, but there are some problems.
Problem:
- There is an issue with the auto ID generation in the UserConfig.
- in the AuthBusinessServiceImpl where throwIf(() -> userService.checkByEmail...
I fixed the problems to test the code but then rolled back the changes for a better solution.
Member
There was a problem hiding this comment.
let's have a short call on telegram on Saturday for clarify this issue
… into feature_#83_insert_default_language_for_user
…//github.com/webperside/course-erp-backend into feature_#83_insert_default_language_for_user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.