Migrate HyperHDR webOS loader to Qt 6 and add HDR/Dolby Vision LUT resources#44
Conversation
- update build workflow for Qt6 compatibility - improve build and packaging pipeline - replace legacy LUT package with compressed LUT resources - add HDR and Dolby Vision LUT tables - update application metadata and package version
| ls -R | ||
| mkdir -p ./dist/service/hyperhdr | ||
| cp -r ./hyperhdr-build/* ./dist/service/hyperhdr/ | ||
| cp -r ./hyperhdr-build/* ./dist/service/hyperhdr/ |
There was a problem hiding this comment.
Thanks for reviewing.
I double-checked the current branch:
- The copy command appears only once in
build.yml. git diff --checkreports no trailing whitespace issues.- My local branch is clean and matches the PR commit.
Could you point me to the exact line or commit that should be adjusted if I'm missing something?
There was a problem hiding this comment.
grep -n -e '\s\+$' .github/workflows/build.yml
There was a problem hiding this comment.
I checked the commit again using git diff-tree --check, found the issues with the trailing spaces, fixed them, and pushed a follow-up commit.
|
Please don't merge without approval in this repo. There was already #42 open with a different approach. Also, I'm not sure if v22 beta should have been released to homebrew channel users as it's not a stable release. |
| { | ||
| "id": "org.webosbrew.hyperhdr.loader", | ||
| "version": "0.1.12", | ||
| "version": "22.0.0", |
There was a problem hiding this comment.
This has already been released to users and now it will require us to diverge from upstream as we have to bump the version again for the next release. I think that was probably why we used arbitrary version tags here
There was a problem hiding this comment.
Hello,
Okay, that was my mistake. I apologize for that. As for the version number, I wrote in the PR that, in my opinion, it reflects the actual original HyperHDR version, so there won't be any further confusion or questions.
According to https://github.com/awawa-dev/HyperHDR/releases/tag/v22.0.0.0beta2, v22.0.0.0beta2 has been released.
I’ll wait for approval before merging it in the future. You can change anything. Please make the necessary corrections.
|
@sundermann This is my fault. I wasn't aware which projects were being actively maintained. |
Summary
This PR migrates the webOS loader build pipeline to Qt 6 and updates LUT resource handling.
Changes
Notes
The previous LUT package
flat_lut_lin_tables.3dhas been replaced with separate, compressed LUT resources to improve resource management and more efficiently support SDR, HDR, and Dolby Vision workflows when using the NV12 inhyperion-webos.