Skip to content

Bessie(Yunzhu)'s commit #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bessiezhuo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bessie(Yunzhu)'s commit #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bessie.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
function bessie() {
// return "Bessie says hello."

@bessiezhuo bessiezhuo May 12, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments

return "Bessie says Hello!";

@bessiezhuo bessiezhuo May 12, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: avoid hard-coding string and use variable public static final BESSIE_HELLO="Bessie says Hello!"

@bessiezhuo bessiezhuo May 12, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return "Bessie says Hello!";
return BESSIE_HELLO;

}
2 changes: 2 additions & 0 deletions hello.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<script src="bob.js"></script>
<script src="elisabeth.js"></script>
<script src="robert.js"></script>
<script src="bessie.js"></script>
<title>Hello Team</title>
</head>
<body>
Expand Down Expand Up @@ -31,6 +32,7 @@
updateText(elisabeth(), textContent);
updateText(bob(), textContent);
updateText(robert(), textContent);
updateText(bessie(), textContent);
// Note: we need to add more function here for everyone to say hello.

// append the text content to the document
Expand Down