Skip to content

Add dynamic webcam overlay dimensions#682

Draft
surim0n wants to merge 1 commit into
webadderallorg:mainfrom
surim0n:codex/dynamic-webcam-overlay-shape
Draft

Add dynamic webcam overlay dimensions#682
surim0n wants to merge 1 commit into
webadderallorg:mainfrom
surim0n:codex/dynamic-webcam-overlay-shape

Conversation

@surim0n

@surim0n surim0n commented Jun 15, 2026

Copy link
Copy Markdown

Summary

  • Replaces the single webcam size control with separate width and height controls, while falling back to the old size value for existing projects.
  • Removes the square lock from webcam crop editing and lets crop aspect drive the overlay height when width/height are still linked.
  • Updates live preview, canvas export, and the modern Pixi renderer to draw rectangular webcam overlays correctly.
  • Skips the native static-layout shortcut for rectangular/cropped webcam overlays so export falls back to the renderer that supports the shape.
  • Adds locale labels and focused tests for overlay math and native static-layout eligibility.

Verification

  • npx vitest --run src/components/video-editor/webcamOverlay.test.ts src/lib/exporter/modernVideoExporter.nativeStaticLayout.test.ts
  • npx vitest --run src/lib/exporter/frameRenderer.test.ts src/lib/exporter/modernFrameRenderer.test.ts src/components/video-editor/webcamOverlay.test.ts src/lib/exporter/modernVideoExporter.nativeStaticLayout.test.ts
  • npx tsc --noEmit --noUnusedLocals false --noUnusedParameters false
  • npx biome check src/components/video-editor/WebcamCropControl.tsx src/components/video-editor/webcamOverlay.ts src/components/video-editor/webcamOverlay.test.ts src/components/video-editor/types.ts src/components/video-editor/projectPersistence.ts src/lib/exporter/modernVideoExporter.ts src/lib/exporter/modernVideoExporter.nativeStaticLayout.test.ts

Known existing check failures

  • npx tsc --noEmit fails on existing unused code in src/components/video-editor/videoPlayback/zoomRegionUtils.ts.
  • npm run i18n:check fails on existing missing/extra locale keys unrelated to these new webcam labels.
  • npm test has one unrelated failure in electron/ipc/paths/binaries.test.ts around Windows helper path resolution; the focused renderer/webcam tests pass.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2bfd5cac-9b59-409b-9796-f97bd669dca2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant